From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhigang Wang <zhigang.x.wang@oracle.com>
Subject: Re: libcacard is been installed to /usr/lib while
	libdir=/usr/lib64
Date: Tue, 20 May 2014 09:21:04 -0400
Message-ID: <537B56C0.20201@oracle.com>
References: <537162DD.7000304@oracle.com>
	<1400166650.19926.14.camel@kazak.uk.xensource.com>
	<5374E338.4060908@oracle.com>
	<1400589649.6946.31.camel@kazak.uk.xensource.com>
	<20140520130224.GA19255@aepfle.de> <537B5383.5010401@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <537B5383.5010401@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Olaf Hering <olaf@aepfle.de>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/20/2014 09:07 AM, Andrew Cooper wrote:
> On 20/05/14 14:02, Olaf Hering wrote:
>> On Tue, May 20, Ian Campbell wrote:
>>
>>>> For qemu: we didn't pass the --libdir when we configure it, so it uses the default one: $PREFIX/lib
>>> Thanks. I think your patch is probably the correct one then. Please can
>>> you submit with a proper changelog.
>> Likely not.
>> Since the included qemu is a private part of xen itself, it should
>> install stuff into $prefix/lib/xen/ instead of overwriting system files.
>> This most likely means qemu has to be build with rpath to really use its
>> own libs, if there are any.
>>
>> Olaf
> 
> I agree.  Having the Xen build system build itself non-xen components
> makes integrating the results into a real system very difficult without
> collisions.
> 
> In this case, any qemu built by the Xen build system is private to Xen,
> and should not install as if it were the system qemu.
> 
> The same goes for other 3rd party components.
> 
> ~Andrew

I agree with the direction you mentioned.

On CentOS, libcacard is built as a separate RPM and installed to /usr/lib64,
which will conflict with our build with this patch.

But keep our libcacard under /usr/lib also seems wrong.

Could you please generate a patch to put libcacard etc staff into
$prefix/lib/xen and build qemu with rpath?

I'm not a expert on these staff but I can test it.

Thanks,

Zhigang