From: Jacek Konieczny <jajcus@jajcus.net>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Mariusz Mazur <mmazur@axeos.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [BUG] libxenstat and xentop confused by renamed VIF interfaces
Date: Wed, 21 May 2014 13:35:41 +0200 [thread overview]
Message-ID: <537C8F8D.5040401@jajcus.net> (raw)
In-Reply-To: <1400668184.4856.10.camel@kazak.uk.xensource.com>
On 05/21/14 12:29, Ian Campbell wrote:
> On Wed, 2014-05-21 at 09:52 +0200, Jacek Konieczny wrote:
>> I think the solution would be to look-up the actual interface name or
>> index in sysfs, e.g. under /sys/devices/vif-${domind}-*.
>
> Sounds plausible.
>
> Or perhaps check that /sys/class/net/${dev}/device/devtype contains
> "vif"? Might want to handle tap devices too.
I am not sure we could easily map a renamed tap (can they be renamed?)
device to a domid.
> Perhaps parse the content of /sys/class/net/vif1.0/device/nodename to
> get the domid and devid?
I think I could prepare the patch.
One question: can I assume /sys is always mounted and the
'/sys/.../device/nodename', contains 'backend/vif/$domid/*' or should
there be a fall-back to the old behaviour?
BTW, when 'device/nodename' exists and contains 'backend/vif/*' we don't
need to check 'device/devtype' – one file access less.
Jacek
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-05-21 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 7:52 [BUG] libxenstore and xentop confused by renamed VIF interfaces Jacek Konieczny
2014-05-21 8:15 ` [BUG] libxenstat " Jacek Konieczny
2014-05-21 10:29 ` [BUG] libxenstore " Ian Campbell
2014-05-21 10:48 ` [BUG] libxenstat " Jacek Konieczny
2014-05-21 10:53 ` Ian Campbell
2014-05-21 11:35 ` Jacek Konieczny [this message]
2014-05-21 11:52 ` Ian Campbell
2014-05-21 14:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C8F8D.5040401@jajcus.net \
--to=jajcus@jajcus.net \
--cc=Ian.Campbell@citrix.com \
--cc=mmazur@axeos.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).