From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v6 08/19] x86/VPMU: Add public xenpmu.h Date: Wed, 21 May 2014 09:56:58 -0400 Message-ID: <537CB0AA.6030900@oracle.com> References: <1399996413-1998-1-git-send-email-boris.ostrovsky@oracle.com> <1399996413-1998-9-git-send-email-boris.ostrovsky@oracle.com> <5626238.Vjzfje9UQu@amur> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5626238.Vjzfje9UQu@amur> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dietmar Hahn Cc: kevin.tian@intel.com, keir@xen.org, JBeulich@suse.com, jun.nakajima@intel.com, andrew.cooper3@citrix.com, donald.d.dugger@intel.com, xen-devel@lists.xen.org, suravee.suthikulpanit@amd.com List-Id: xen-devel@lists.xenproject.org On 05/21/2014 03:19 AM, Dietmar Hahn wrote: > Am Dienstag 13 Mai 2014, 11:53:22 schrieb Boris Ostrovsky: >> Add pmu.h header files, move various macros and structures that will be >> shared between hypervisor and PV guests to it. >> >> Move MSR banks out of architectural PMU structures to allow for larger sizes >> in the future. The banks are allocated immediately after the context and >> PMU structures store offsets to them. >> >> Signed-off-by: Boris Ostrovsky >> Reviewed-by: Dietmar Hahn >> Tested-by: Dietmar Hahn > It seems I didn't test right because calling > # xl debug-keys q > when running a HVM linux guest crashs the hypervisor. > Please see below. Yes, trying to dereference pointer that it explicitly set to NULL two lines above is not a particularly good idea. Thanks for debugging this. -boris