From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC] VT-d: honor firmware-first mode in
 XSA-59 workaround code
Date: Thu, 22 May 2014 10:34:36 +0100
Message-ID: <537DC4AC.4030505@citrix.com>
References: <537CEBD20200007800014A29@mail.emea.novell.com>
	<537CD574.3030701@citrix.com>
	<537DBFB00200007800014C79@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1WnPOb-00049e-Gb
	for xen-devel@lists.xenproject.org; Thu, 22 May 2014 09:34:41 +0000
In-Reply-To: <537DBFB00200007800014C79@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Yang Z Zhang <yang.z.zhang@intel.com>, xen-devel <xen-devel@lists.xenproject.org>, Malcolm Crossley <malcolm.crossley@citrix.com>, Kevin Tian <kevin.tian@intel.com>, Donald D Dugger <donald.d.dugger@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 22/05/14 08:13, Jan Beulich wrote:
>>>> On 21.05.14 at 18:33, <andrew.cooper3@citrix.com> wrote:
>> On 21/05/14 17:09, Jan Beulich wrote:
>>> When firmware-first mode is being indicated by firmware, we shouldn't
>>> be modifying AER registers - these ar considered to be owned by
>> "these are"
>>
>>> firmware in that case. Violating this is being reported to result in
>>> SMI (or was it SCI?) storms.
>> SMM livelock.
> IOW "SMI storm".

It wasn't completely clear from the BIOS engineer's description whether
it was a single infinite loop in SMM mode, or an SMI storm, but the
overall effects are still the same.

>
>> The exact problem was a 2.6.32 kernel ignoring firmware-first and
>> disabling reporting on the root ports but not endpoint devices, causing
>> the SMM handler to fail to find the issue, and fail to clear the SMI.
>>
>> However, as part of the investigation, we identified that Xen was also
>> violating firmware-first as part of XSA-59
> So has a problem solely with the XSA-59 workaround (i.e. without an
> ignorant kernel) then been observed at all?
>
> Jan
>

Correct

~Andrew