From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v5 7/9] tools: arm: prepare guest FDT
 building for multiple RAM banks
Date: Thu, 22 May 2014 11:22:46 +0100
Message-ID: <537DCFF6.3050805@linaro.org>
References: <1400751582.11409.46.camel@kazak.uk.xensource.com>
	<1400752004-9731-7-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1400752004-9731-7-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, tim@xen.org, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 22/05/14 10:46, Ian Campbell wrote:
> -    assert(rambank_size[0] != 0);
> +    assert(dom->rambank_size[0] != 0);
>       assert(ramsize == 0); /* Too much RAM is rejected above */
>
>       dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) * p2m_size);
> @@ -354,11 +353,10 @@ int arch_setup_meminit(struct xc_dom_image *dom)
>           dom->p2m_host[pfn] = INVALID_MFN;
>
>       /* setup initial p2m and allocate guest memory */
> -    for ( i = 0; rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
> -    {
> +    for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ ) {

We are in libxc, so the previous coding style was valid, i.e:
for ( ... )
{
}

Other than this minor change:

Acked-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall