From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v8 06/13] xen/arm: keep track of the GICH_LR
 used for the irq in struct pending_irq
Date: Thu, 22 May 2014 16:37:33 +0100
Message-ID: <537E19BD.7060804@linaro.org>
References: <alpine.DEB.2.02.1405221325140.14596@kaball.uk.xensource.com>
	<1400761950-25035-6-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1400761950-25035-6-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,

Sorry, I'm jumping into the discussion a bit late.

On 22/05/14 13:32, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> ---
>
> Changes in v5:
> - don't print p->lr in case the irq is in lr_pending, as it doesn't have
> an LR associate to it;
> - improve packing of struct pending_irq;

As the above line will be dropped when this patch will be committed 
(because it's after the ---), it won't be clear why you move the irq field.

Could you add a line in the commit message?

Other than that:
Acked-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall