From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v8 13/13] gic_remove_from_queues: take a
 lock on the right vcpu
Date: Thu, 22 May 2014 17:10:14 +0100
Message-ID: <537E2166.1060401@linaro.org>
References: <alpine.DEB.2.02.1405221325140.14596@kaball.uk.xensource.com>
	<1400761950-25035-13-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1400761950-25035-13-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,

On 22/05/14 13:32, Stefano Stabellini wrote:
> At the moment gic_remove_from_queues doesn't handle the case where the
> guest kernel disables an irq on a different vcpu compared to the one
> currently receiving the interrupt.
> Make sure to take the right vcpu lock before removing the irq from
> lr_queue.

I see the same issue with vgic_enable_irqs. We may inject to the wrong 
VCPU (i.e other than 0).

I think we should have the same case in vgic_enable_irqs.

Cheers,

-- 
Julien Grall