From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 05/14] arch/arm: unmap partially-mapped I/O-memory regions Date: Sun, 25 May 2014 17:04:15 +0100 Message-ID: <5382147F.3010408@linaro.org> References: <1401015115-7610-1-git-send-email-avanzini.arianna@gmail.com> <1401015115-7610-6-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401015115-7610-6-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini , xen-devel@lists.xen.org Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org Hi Arianna, On 25/05/14 11:51, Arianna Avanzini wrote: > This commit changes the interface of apply_p2m_changes() to accept > optionally the pointer to a counter of successfully performed > mappings; such a counter is used only in case of INSERT operation. > If an error is encountered during the operation, and therefore the > mapping is only partially performed, such a counter is useful to > let the caller be able to undo what has just been done. I don't think you need to introduce another argument to apply_p2m_changes. You can directly call apply_p2m_changes with the whole range. > +int unmap_mmio_regions(struct domain *d, > + unsigned long start_gfn, > + unsigned long nr_mfns, > + unsigned long mfn); The commit message doesn't mention anything about the addition of unmap_mmio_regions as a new interface. Regards, -- Julien Grall