From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 08/14] xen/common: move memory_type_changed() function to common code Date: Sun, 25 May 2014 17:15:21 +0100 Message-ID: <53821719.9060305@linaro.org> References: <1401015115-7610-1-git-send-email-avanzini.arianna@gmail.com> <1401015115-7610-9-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401015115-7610-9-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini , xen-devel@lists.xen.org Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org Hi Arianna, On 25/05/14 11:51, Arianna Avanzini wrote: > Currently, MTRR-related code is not available for the ARM architecture. > Given that the memory_type_changed() function must be called also from > common code, its invocation is currently ifdef'd out to be only compiled > in on an x86 machine. This commit adds an empty stub for ARM, instead, > also moving the function's definition to common code. Hrmmm, MTRR doesn't have any sense on ARM, IIRC, this is only x86-related. So we should not expose this concept (i.e naming the include and source file) to the common architecture. I would move the function declaration in xen/p2m*.h and add the stub for arm in arch/arm/p2m.c Regards, -- Julien Grall