From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>,
Arianna Avanzini <avanzini.arianna@gmail.com>
Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com,
etrudeau@broadcom.com, tim@xen.org,
viktor.kleinik@globallogic.com
Subject: Re: [PATCH v7 10/10] xen/common: do not implicitly permit access to mapped I/O memory
Date: Sun, 25 May 2014 18:14:57 +0100 [thread overview]
Message-ID: <53822511.1040604@linaro.org> (raw)
In-Reply-To: <5368C22B020000780000F3C9@mail.emea.novell.com>
Hi Jan,
On 06/05/14 10:06, Jan Beulich wrote:
>> @@ -838,7 +842,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>> break;
>>
>> ret = -EPERM;
>> - if ( !iomem_access_permitted(current->domain, mfn, mfn_end) )
>> + if ( !iomem_access_permitted(d, mfn, mfn_end) )
>
> I'm not sure if we shouldn't rather be conservative here and check
> both domains' permissions.
I think we only need to check the permission of the current domain.
Checking the permission of the guest is not necessary here. Hence, the
code to map a region will be more difficult. We will have first call
iomem_permission then call memory_mapping.
I would prefer to keep the current permission check ie:
if ( !iomem_access_permitted(current->domain, ...) )
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-05-25 17:14 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 15:54 [PATCH v7 00/10] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Arianna Avanzini
2014-05-05 15:54 ` [PATCH v7 01/10] arch/arm: domain build: let dom0 access I/O memory of mapped devices Arianna Avanzini
2014-05-05 15:54 ` [PATCH v7 02/10] arch/arm: add consistency check to REMOVE p2m changes Arianna Avanzini
2014-05-06 16:51 ` Julien Grall
2014-05-06 16:52 ` Julien Grall
2014-05-05 15:54 ` [PATCH v7 03/10] arch/arm: let map_mmio_regions() take pfn as parameters Arianna Avanzini
2014-05-05 15:54 ` [PATCH v7 04/10] arch/arm: let map_mmio_regions() use start and count Arianna Avanzini
2014-05-05 18:55 ` Julien Grall
2014-05-07 11:03 ` Ian Campbell
2014-05-19 13:47 ` Julien Grall
2014-05-05 15:54 ` [PATCH v7 05/10] arch/x86: check if mapping exists before memory_mapping removes it Arianna Avanzini
2014-05-06 8:25 ` Jan Beulich
2014-05-05 15:54 ` [PATCH v7 06/10] xen/x86: factor out map and unmap from the memory_mapping DOMCTL Arianna Avanzini
2014-05-06 8:35 ` Jan Beulich
2014-05-05 15:54 ` [PATCH v7 07/10] xen/common: move the memory_mapping DOMCTL hypercall to common code Arianna Avanzini
2014-05-06 8:40 ` Jan Beulich
2014-05-07 11:09 ` Ian Campbell
2014-05-10 0:26 ` Arianna Avanzini
2014-05-12 8:29 ` Jan Beulich
2014-05-07 11:10 ` Ian Campbell
2014-05-06 16:54 ` Julien Grall
2014-05-10 1:20 ` Arianna Avanzini
2014-05-10 9:03 ` Julien Grall
2014-05-05 15:54 ` [PATCH v7 08/10] tools/libxl: parse optional start gfn from the iomem config option Arianna Avanzini
2014-05-05 15:54 ` [PATCH v7 09/10] tools/libxl: handle the iomem parameter with the memory_mapping hcall Arianna Avanzini
2014-05-06 8:44 ` Jan Beulich
2014-05-07 11:16 ` Ian Campbell
2014-05-05 15:54 ` [PATCH v7 10/10] xen/common: do not implicitly permit access to mapped I/O memory Arianna Avanzini
2014-05-06 9:06 ` Jan Beulich
2014-05-10 1:10 ` Arianna Avanzini
2014-05-12 8:35 ` Jan Beulich
2014-05-25 17:14 ` Julien Grall [this message]
2014-05-26 9:03 ` Jan Beulich
2014-05-26 10:14 ` Jan Beulich
2014-05-26 10:53 ` Julien Grall
2014-05-26 11:14 ` Jan Beulich
2014-05-26 11:24 ` Julien Grall
2014-05-26 11:37 ` Jan Beulich
2014-05-26 11:42 ` Julien Grall
2014-05-26 11:51 ` Jan Beulich
2014-05-26 12:15 ` Julien Grall
2014-05-26 13:22 ` Jan Beulich
2014-05-26 14:26 ` Julien Grall
2014-05-26 15:00 ` Jan Beulich
2014-05-06 8:21 ` [PATCH v7 00/10] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53822511.1040604@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=avanzini.arianna@gmail.com \
--cc=dario.faggioli@citrix.com \
--cc=etrudeau@broadcom.com \
--cc=julien.grall@citrix.com \
--cc=keir@xen.org \
--cc=paolo.valente@unimore.it \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=viktor.kleinik@globallogic.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).