From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 10/14] xen/common: move the memory_mapping DOMCTL hypercall to common code Date: Mon, 26 May 2014 12:03:38 +0100 Message-ID: <53831F8A.8060604@linaro.org> References: <1401015115-7610-1-git-send-email-avanzini.arianna@gmail.com> <1401015115-7610-11-git-send-email-avanzini.arianna@gmail.com> <53821D7F.4040701@linaro.org> <53832E940200007800015AED@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53832E940200007800015AED@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Arianna Avanzini Cc: Ian.Campbell@eu.citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, tim@xen.org, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On 26/05/14 11:07, Jan Beulich wrote: >>>> On 25.05.14 at 18:42, wrote: >> On 25/05/14 11:51, Arianna Avanzini wrote: >>> +#include >>> + >> >> That would make more sense to include asm/p2m.h in xen/p2m-common.h >> rather than the invert. >> >> This will avoid issue such as, a source file is trying to include >> xen/p2m-common.h directly without adding asm/p2m.h before. This will >> result to a compilation issue. >> >> Anyway, if the maintainers are fine with this solution, let's stick > > I actually asked for it to be done this way. Ok, thanks. I was unable to find the email where you asked it. In any case, I don't think we should expose mfn_t and _mfn to ARM. All the P2M interface used in common code, take an unsigned long in parameter. Regards, -- Julien Grall