From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 07/16] arm/xen: move GIC context data structure to gic driver Date: Mon, 26 May 2014 15:32:25 +0100 Message-ID: <53835079.1080707@linaro.org> References: <1401100009-7326-1-git-send-email-vijay.kilari@gmail.com> <1401100009-7326-8-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401100009-7326-8-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hi Vijay, On 26/05/14 11:26, vijay.kilari@gmail.com wrote: > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h > index 61a498f..f46b631 100644 > --- a/xen/include/asm-arm/domain.h > +++ b/xen/include/asm-arm/domain.h > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -261,8 +262,10 @@ struct arch_vcpu > uint32_t csselr; > register_t vmpidr; > > - uint32_t gic_hcr, gic_vmcr, gic_apr; > - uint32_t gic_lr[64]; > + /* Holds gic context data */ > + union gic_state_data gic; > + > + uint64_t event_mask; Why do you add back this field? It has been dropped on upstream... Regards, -- Julien Grall