From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 11/16] xen/arm: calculate vgic irq rank
 based on register size
Date: Tue, 27 May 2014 12:56:49 +0100
Message-ID: <53847D81.7000005@linaro.org>
References: <1401100009-7326-1-git-send-email-vijay.kilari@gmail.com>
	<1401100009-7326-12-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1401100009-7326-12-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 05/26/2014 11:26 AM, vijay.kilari@gmail.com wrote:
> -        *r = ( (v->domain->max_vcpus<<5) & GICD_TYPE_CPUS )
> -            |( ((v->domain->arch.vgic.nr_lines/32)) & GICD_TYPE_LINES );
> +        *r = ( (v->domain->max_vcpus << 5) & GICD_TYPE_CPUS )
> +            |( ((v->domain->arch.vgic.nr_lines / 32)) & GICD_TYPE_LINES );

Why these changes?

>          vgic_unlock(v);
>          return 1;
>      case GICD_IIDR:
> -        if ( dabt.size != 2 ) goto bad_width;
> +        if ( dabt.size != DABT_WORD ) goto bad_width;
>          /*
>           * XXX Do we need a JEP106 manufacturer ID?
>           * Just use the physical h/w value for now
> @@ -119,8 +119,8 @@ static int vgic_distr_mmio_read(struct vcpu *v, mmio_info_t *info)
>          goto read_as_zero;
>  
>      case GICD_ISENABLER ... GICD_ISENABLERN:
> -        if ( dabt.size != 2 ) goto bad_width;
> -        rank = vgic_irq_rank(v, 1, gicd_reg - GICD_ISENABLER);
> +        if ( dabt.size != DABT_WORD ) goto bad_width;
> +        rank = vgic_irq_rank(v, 1, gicd_reg - GICD_ISENABLER, DABT_WORD);

In your commit message you explicitly say that use DABT_* will help you
to get the register offset but... you still hardcode the size.

Why can't you use dabt.size here? And all the other places.

Regards,

-- 
Julien Grall