xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: jinsong.liu@alibaba-inc.com, chegger@amazon.de, xen-devel@lists.xen.org
Subject: Re: [PATCH] x86, mce: Consolidate AMD mcheck initialization
Date: Tue, 27 May 2014 10:17:24 -0500	[thread overview]
Message-ID: <5384AC84.2000300@amd.com> (raw)
In-Reply-To: <537E27800200007800015063@mail.emea.novell.com>

On 5/22/2014 9:36 AM, Jan Beulich wrote:
>>>> On 21.05.14 at 23:06, <aravind.gopalakrishnan@amd.com> wrote:
>> amd_k8.c did a lot of common work and very little K8
>> specific work. So merge init functions of amd_f10.c and
>> amd_k8.c and move it into the common amd_mcheck_init
>> handler. With that done, there is not much left in either
>> files, so fold all code into just one file - mce_amd.c
>>
>> While at it, update the comments regarding documentation
>> with correct URL's and revision numbers.
>>
>> Also, update copyright info.
>>
>> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
>> ---
>>   xen/arch/x86/cpu/mcheck/Makefile  |    2 -
>>   xen/arch/x86/cpu/mcheck/amd_f10.c |  118 ---------------------------
>>   xen/arch/x86/cpu/mcheck/amd_k8.c  |  117 ---------------------------
>>   xen/arch/x86/cpu/mcheck/mce_amd.c |  162 +++++++++++++++++++++++++++++++++----
> Content-wise this looks fine, but most of the additions to mce_amd.c
> need cleaning up coding-style-wise.
>
Done. Think I caught it all..
Sending it out as V2.

Thanks,
-Aravind.

      parent reply	other threads:[~2014-05-27 15:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 21:06 [PATCH] x86, mce: Consolidate AMD mcheck initialization Aravind Gopalakrishnan
2014-05-22 14:36 ` Jan Beulich
2014-05-22 14:46   ` Aravind Gopalakrishnan
2014-05-27 15:17   ` Aravind Gopalakrishnan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5384AC84.2000300@amd.com \
    --to=aravind.gopalakrishnan@amd.com \
    --cc=JBeulich@suse.com \
    --cc=chegger@amazon.de \
    --cc=jinsong.liu@alibaba-inc.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).