From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aravind Gopalakrishnan Subject: Re: [PATCH] x86, mce: Consolidate AMD mcheck initialization Date: Tue, 27 May 2014 10:17:24 -0500 Message-ID: <5384AC84.2000300@amd.com> References: <1400706364-3371-1-git-send-email-aravind.gopalakrishnan@amd.com> <537E27800200007800015063@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <537E27800200007800015063@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: jinsong.liu@alibaba-inc.com, chegger@amazon.de, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 5/22/2014 9:36 AM, Jan Beulich wrote: >>>> On 21.05.14 at 23:06, wrote: >> amd_k8.c did a lot of common work and very little K8 >> specific work. So merge init functions of amd_f10.c and >> amd_k8.c and move it into the common amd_mcheck_init >> handler. With that done, there is not much left in either >> files, so fold all code into just one file - mce_amd.c >> >> While at it, update the comments regarding documentation >> with correct URL's and revision numbers. >> >> Also, update copyright info. >> >> Signed-off-by: Aravind Gopalakrishnan >> --- >> xen/arch/x86/cpu/mcheck/Makefile | 2 - >> xen/arch/x86/cpu/mcheck/amd_f10.c | 118 --------------------------- >> xen/arch/x86/cpu/mcheck/amd_k8.c | 117 --------------------------- >> xen/arch/x86/cpu/mcheck/mce_amd.c | 162 +++++++++++++++++++++++++++++++++---- > Content-wise this looks fine, but most of the additions to mce_amd.c > need cleaning up coding-style-wise. > Done. Think I caught it all.. Sending it out as V2. Thanks, -Aravind.