From: "Jan Beulich" <JBeulich@suse.com>
To: Feng Wu <feng.wu@intel.com>
Cc: keir.xen@gmail.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 3/3] x86: Use alternative mechanism to define CLAC/STAC
Date: Tue, 27 May 2014 16:42:21 +0100 [thread overview]
Message-ID: <5384CE7D020000780001602D@mail.emea.novell.com> (raw)
In-Reply-To: <1401089273-16425-4-git-send-email-feng.wu@intel.com>
>>> On 26.05.14 at 09:27, <feng.wu@intel.com> wrote:
> -#define ASM_STAC ASM_AC(STAC)
> -#define ASM_CLAC ASM_AC(CLAC)
> +#define ASM_CLAC \
> + 661: ASM_NOP3; \
> + .pushsection .altinstr_replacement, "ax"; \
> + 662: __ASM_CLAC; \
> + .popsection; \
> + .pushsection .altinstructions, "a"; \
> + altinstruction_entry 661b, 662b, X86_FEATURE_SMAP, 3, 3; \
> + .popsection
> +
> +#define ASM_STAC \
> + 661: ASM_NOP3; \
> + .pushsection .altinstr_replacement, "ax"; \
> + 662: __ASM_STAC; \
> + .popsection; \
> + .pushsection .altinstructions, "a"; \
> + altinstruction_entry 661b, 662b, X86_FEATURE_SMAP, 3, 3; \
> + .popsection
I made the same comment on your original SMAP patches already:
There's no point in having all this duplication. All you want to
replace if ASM_AC().
Jan
prev parent reply other threads:[~2014-05-27 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 7:27 [PATCH 0/3] x86: Use alternative mechanism to define CLAC/STAC Feng Wu
2014-05-26 7:27 ` [PATCH 1/3] x86: Add definitions for NOP operation Feng Wu
2014-05-26 15:04 ` Andrew Cooper
2014-05-26 7:27 ` [PATCH 2/3] x86: Port the basic alternative mechanism from Linux to Xen Feng Wu
2014-05-26 15:40 ` Andrew Cooper
2014-05-26 16:16 ` Jan Beulich
2014-05-27 6:13 ` Wu, Feng
2014-05-27 9:30 ` Jan Beulich
2014-05-27 15:35 ` Jan Beulich
2014-05-26 7:27 ` [PATCH 3/3] x86: Use alternative mechanism to define CLAC/STAC Feng Wu
2014-05-26 15:49 ` Andrew Cooper
2014-05-26 16:18 ` Jan Beulich
2014-05-26 16:22 ` Andrew Cooper
2014-05-27 6:24 ` Wu, Feng
2014-05-27 15:42 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384CE7D020000780001602D@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=feng.wu@intel.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).