From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 02/16] xen/arm: make mmio handlers domain
	specific
Date: Wed, 28 May 2014 15:11:33 +0100
Message-ID: <5385EE95.9030303@linaro.org>
References: <1401100009-7326-1-git-send-email-vijay.kilari@gmail.com>
	<1401100009-7326-3-git-send-email-vijay.kilari@gmail.com>
	<53833494.2000008@linaro.org>
	<alpine.DEB.2.02.1405281505140.4779@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1405281505140.4779@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian.Campbell@citrix.com, vijay.kilari@gmail.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 05/28/2014 03:05 PM, Stefano Stabellini wrote:
>>
>> Rather than moving a whole chunk of code, why can't you add forward
>> declaration for vgic_disk_mmio_{read,write}?
> 
> I think it would be OK either way

IHMO, it's more difficult to see what was change with this solution.

This serie is quite difficult to review (because of the number of line
changes). If we can avoid few of them it's better.

Regards,

-- 
Julien Grall