From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aravind Gopalakrishnan Subject: Re: [PATCH V3] x86, mce: Consolidate AMD mcheck initialization Date: Wed, 28 May 2014 10:59:23 -0500 Message-ID: <538607DB.2030900@amd.com> References: <1401292307-3848-1-git-send-email-aravind.gopalakrishnan@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401292307-3848-1-git-send-email-aravind.gopalakrishnan@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: JBeulich@suse.com, chegger@amazon.de, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 5/28/2014 10:51 AM, Aravind Gopalakrishnan wrote: > amd_k8.c did a lot of common work and very little K8 > specific work. So merge init functions of amd_f10.c and > amd_k8.c and move it into the common amd_mcheck_init > handler. With that done, there is not much left in either > files, so fold all code into just one file - mce_amd.c > > While at it, update the comments regarding documentation > with correct URL's and revision numbers. > > Also, update copyright info. > > Changes in V2: > - Fix coding style issues > Changes in V3: > - More coding style fixes. > > Signed-off-by: Aravind Gopalakrishnan > --- > xen/arch/x86/cpu/mcheck/Makefile | 2 - > xen/arch/x86/cpu/mcheck/amd_f10.c | 118 -------------------------- > xen/arch/x86/cpu/mcheck/amd_k8.c | 117 -------------------------- > xen/arch/x86/cpu/mcheck/mce_amd.c | 167 +++++++++++++++++++++++++++++++++---- > 4 files changed, 151 insertions(+), 253 deletions(-) > delete mode 100644 xen/arch/x86/cpu/mcheck/amd_f10.c > delete mode 100644 xen/arch/x86/cpu/mcheck/amd_k8.c > > Missed a space between '--dry-run' and Jinsong's email. :( Resending it with corrected mail id. -Aravind.