From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 11/16] xen/arm: calculate vgic irq rank based on register size Date: Fri, 30 May 2014 11:54:41 +0100 Message-ID: <53886371.5030405@linaro.org> References: <1401100009-7326-1-git-send-email-vijay.kilari@gmail.com> <1401100009-7326-12-git-send-email-vijay.kilari@gmail.com> <53847D81.7000005@linaro.org> <53885659.1050903@linaro.org> <53885F17.4080902@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , "xen-devel@lists.xen.org" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 30/05/14 11:51, Vijay Kilari wrote: > On Fri, May 30, 2014 at 4:06 PM, Julien Grall wrote: >> With your explanation, I don't see any reason to replace all the dabt.size >> != number by dat.size != DABT_*. > > Two things are done here > (1) In the code 'dabt.size != number' this number is always > BYTE/HALF_WORD/WORD/DOUBLE > defined by hsr registers. Instead of checking for hard coded > values I used hsr defined values. > (2) The vgic_irq_rank also depends on the same hsr defined values > to calculate irq rank. > Also, this make vgic_irq_rank generic as it takes register > size as parameter to calculate irq rank instead > of hard coding to value 2 in previous patches Please add theses explanations in the commit message. It's easier to understand the purpose of this patch with that. Regards -- Julien Grall