Re: [PATCH RFC 14/23] hotplug: add FreeBSD vif-bridge

["Roger Pau Monné" <roger.pau@citrix.com>]

On 28/04/14 16:39, Ian Campbell wrote:
> On Wed, 2014-04-16 at 16:13 +0200, Roger Pau Monne wrote:
>> Add a simple vif-bridge script, that takes care of adding network
>> backends (tap or xnb) to a pre-configured bridge.
> 
> Compared with the Linux one it lacks the handling of the vifname
> property and the attempt to provide a default if no bridge was
> specified. This is probably acceptable I suppose.

I would like to explicitly avoid providing a default bridge if no bridge
was specified, I think this should probably be done in the global xl
configuration file.

>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> ---
>>  tools/hotplug/FreeBSD/Makefile   |    2 +-
>>  tools/hotplug/FreeBSD/vif-bridge |   41 ++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 42 insertions(+), 1 deletions(-)
>>  create mode 100644 tools/hotplug/FreeBSD/vif-bridge
>>
>> diff --git a/tools/hotplug/FreeBSD/Makefile b/tools/hotplug/FreeBSD/Makefile
>> index c7ffc51..6480aa5 100644
>> --- a/tools/hotplug/FreeBSD/Makefile
>> +++ b/tools/hotplug/FreeBSD/Makefile
>> @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
>>  include $(XEN_ROOT)/tools/Rules.mk
>>  
>>  # Xen script dir and scripts to go there.
>> -XEN_SCRIPTS =
>> +XEN_SCRIPTS = vif-bridge
>>  
>>  XEN_SCRIPT_DATA =
>>  
>> diff --git a/tools/hotplug/FreeBSD/vif-bridge b/tools/hotplug/FreeBSD/vif-bridge
>> new file mode 100644
>> index 0000000..b36d075
>> --- /dev/null
>> +++ b/tools/hotplug/FreeBSD/vif-bridge
>> @@ -0,0 +1,41 @@
>> +#!/bin/sh -e
>> +#
>> +# FreeBSD hotplug script for attaching xnb* interfaces to bridges
>> +#
>> +# Parameters:
>> +#	$1: xenstore backend path of the vif
>> +#	$2: action, either "add" or "remove"
>> +#
>> +# Environment variables:
>> +#	$iface_dev: name of the backend device (xnb<domid>.<handle>)
>> +#
>> +
>> +DIR=$(dirname "$0")
>> +. "${DIR}/hotplugpath.sh"
>> +
>> +PATH=${BINDIR}:${SBINDIR}:${LIBEXEC}:${PRIVATE_BINDIR}:/bin:/usr/bin:/sbin:/usr/sbin
>> +export PATH
>> +
>> +xpath=$1
>> +xaction=$2
> 
> OOI why the x prefixes everywhere?

Because they were there on the NetBSD version, but I will remove them in
the next version of the series.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel