Re: [PATCH RFC 14/23] hotplug: add FreeBSD vif-bridge

["Roger Pau Monné" <roger.pau@citrix.com>]

On 02/06/14 15:52, Ian Campbell wrote:
> On Mon, 2014-06-02 at 13:56 +0200, Roger Pau Monné wrote:
>> On 28/04/14 16:39, Ian Campbell wrote:
>>> On Wed, 2014-04-16 at 16:13 +0200, Roger Pau Monne wrote:
>>>> Add a simple vif-bridge script, that takes care of adding network
>>>> backends (tap or xnb) to a pre-configured bridge.
>>>
>>> Compared with the Linux one it lacks the handling of the vifname
>>> property and the attempt to provide a default if no bridge was
>>> specified. This is probably acceptable I suppose.
>>
>> I would like to explicitly avoid providing a default bridge if no bridge
>> was specified, I think this should probably be done in the global xl
>> configuration file.
> 
> Is that what NetBSD does? I know Linux provides one, so FreeBSD should
> either be the same as NetBSD or Linux (so if NetBSD provides a default
> so should FreeBSD).

NetBSD doesn't seem to provide a default bridge, here is what NetBSD
does in vif-bridge:

xbridge=$(xenstore-read "$xpath/bridge")
[...]
brconfig $xbridge add $iface

>>> OOI why the x prefixes everywhere?
>>
>> Because they were there on the NetBSD version, but I will remove them in
>> the next version of the series.
> 
> Feel free to leave them if you would rather not diverge (with the aim of
> eventually merging). Up to you though.

I've removed the "x" prefixes, since I think they are not helpful. Later
on we can remove them from the NetBSD script if there's interest in
merging them.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel