From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v2 2/2] xen/arm: observe itarget setting in vgic_enable_irqs and vgic_disable_irqs
Date: Tue, 03 Jun 2014 17:33:09 +0100 [thread overview]
Message-ID: <538DF8C5.50500@linaro.org> (raw)
In-Reply-To: <1401811627-4389-2-git-send-email-stefano.stabellini@eu.citrix.com>
Hi Stefano,
On 06/03/2014 05:07 PM, Stefano Stabellini wrote:
> +static struct vcpu *get_target_vcpu(struct vcpu *v, unsigned int irq)
> +{
> + int target;
> + struct vgic_irq_rank *rank;
> + struct vcpu *v_target;
> +
> + rank = vgic_irq_rank(v, 1, irq/32);
> + vgic_lock_rank(v, rank);
> + target = byte_read(rank->itargets[(irq%32)/4], 0, irq % 4);
> + target = find_next_bit((const unsigned long *) &target, 8, 0);
It might be interesting to add an ASSERT(target < d->max_vcpus) here.
Other than that this patch looks good to me:
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-06-03 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 16:04 [PATCH v2 0/2] vgic emulation and GICD_ITARGETSR Stefano Stabellini
2014-06-03 16:07 ` [PATCH v2 1/2] xen/arm: ignore guest writes to GICD_ITARGETSR for SPIs Stefano Stabellini
2014-06-03 16:23 ` Ian Campbell
2014-06-03 16:25 ` Julien Grall
2014-06-03 16:07 ` [PATCH v2 2/2] xen/arm: observe itarget setting in vgic_enable_irqs and vgic_disable_irqs Stefano Stabellini
2014-06-03 16:33 ` Julien Grall [this message]
2014-06-06 16:29 ` [PATCH v2 0/2] vgic emulation and GICD_ITARGETSR Ian Campbell
2014-06-06 16:32 ` Ian Campbell
2014-06-09 10:41 ` Stefano Stabellini
2014-06-10 11:16 ` Ian Campbell
2014-06-10 14:10 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538DF8C5.50500@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).