From: Julien Grall <julien.grall@linaro.org>
To: Thomas Leonard <talex5@gmail.com>,
xen-devel@lists.xenproject.org,
"karim.allah.ahmed@gmail.com" <karim.allah.ahmed@gmail.com>
Subject: Re: [PATCH 3/7] mini-os: Moved events code under arch
Date: Wed, 04 Jun 2014 17:23:38 +0100 [thread overview]
Message-ID: <538F480A.50206@linaro.org> (raw)
In-Reply-To: <1401897998-29569-4-git-send-email-talex5@gmail.com>
Hi Thomas,
I'm not sure why you dropped everyone in cc (i.e Minios Maintainers &
Karim).
On 06/04/2014 05:06 PM, Thomas Leonard wrote:
> diff --git a/extras/mini-os/events.c b/extras/mini-os/events.c
> index 2da9b01..c2bda1a 100644
> --- a/extras/mini-os/events.c
> +++ b/extras/mini-os/events.c
[..]
> +
> + arch_init_events();
> }
>
> +void arch_fini_events(void);
It's better to define the prototype in an header so the compiler can
check if the function declaration is actually matching the prototype.
This will avoid error if someone decide to modify the function
declaration without modifying the call-site...
I'm planning to send a patch to enable -Wmissing-prototypes on the
hypervisor side. It might be a good idea to enable -Wmissing-prototypes
on mini-os.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-06-04 16:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 17:49 [PATCH 0/4] mini-os: initial ARM support Thomas Leonard
2014-06-02 17:49 ` [PATCH 1/4] mini-os: Fixed shutdown thread Thomas Leonard
2014-06-03 0:51 ` Samuel Thibault
2014-06-03 9:01 ` Andrew Cooper
2014-06-02 17:49 ` [PATCH 2/4] mini-os: Tidied up code Thomas Leonard
2014-06-03 0:57 ` Samuel Thibault
2014-06-02 17:49 ` [PATCH 3/4] mini-os: Initial commit to port minios to ARM Thomas Leonard
2014-06-03 9:12 ` Julien Grall
2014-06-04 16:06 ` [PATCH 0/7] mini-os: Preparing for ARM support Thomas Leonard
2014-06-04 16:06 ` [PATCH 1/7] mini-os: Fixed shutdown thread Thomas Leonard
2014-06-04 16:06 ` [PATCH 2/7] mini-os: Tidied up code Thomas Leonard
2014-06-04 16:22 ` Andrew Cooper
2014-06-05 10:24 ` Anil Madhavapeddy
2014-06-04 16:06 ` [PATCH 3/7] mini-os: Moved events code under arch Thomas Leonard
2014-06-04 16:23 ` Julien Grall [this message]
2014-06-06 13:54 ` Ian Campbell
2014-06-06 13:57 ` Ian Campbell
2014-06-04 16:06 ` [PATCH 4/7] mini-os: Switched initial C entry point to arch_init Thomas Leonard
2014-06-06 14:05 ` Ian Campbell
2014-06-04 16:06 ` [PATCH 5/7] mini-os: Moved arch-specific xenbus code under arch Thomas Leonard
2014-06-05 14:00 ` Julien Grall
2014-06-06 14:07 ` Ian Campbell
2014-06-04 16:06 ` [PATCH 6/7] mini-os: Added rmb to xenbus code Thomas Leonard
2014-06-05 13:55 ` Julien Grall
2014-06-05 17:45 ` Thomas Leonard
2014-06-06 4:59 ` karim.allah.ahmed
2014-06-06 14:15 ` Ian Campbell
2014-06-06 15:10 ` Samuel Thibault
2014-06-06 16:40 ` Ian Campbell
2014-06-09 13:56 ` Thomas Leonard
2014-06-09 14:04 ` Thomas Leonard
2014-06-04 16:06 ` [PATCH 7/7] mini-os: Moved force_evtchn_callback to header Thomas Leonard
2014-06-06 14:17 ` Ian Campbell
2014-06-09 11:54 ` Thomas Leonard
2014-06-04 16:12 ` [PATCH 0/7] mini-os: Preparing for ARM support Andrew Cooper
2014-06-02 17:49 ` [PATCH 4/4] mini-os: Added FDT support on ARM Thomas Leonard
2014-06-06 13:51 ` Ian Campbell
2014-06-05 14:36 ` [PATCH 0/4] mini-os: initial ARM support Oleksandr Tyshchenko
2014-06-05 14:57 ` Samuel Thibault
2014-06-05 17:20 ` Oleksandr Tyshchenko
2014-06-05 17:31 ` Thomas Leonard
2014-06-05 18:07 ` Oleksandr Tyshchenko
2014-06-05 18:12 ` Thomas Leonard
2014-06-05 18:21 ` Oleksandr Tyshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F480A.50206@linaro.org \
--to=julien.grall@linaro.org \
--cc=karim.allah.ahmed@gmail.com \
--cc=talex5@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).