From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 3/7] mini-os: Moved events code under arch Date: Wed, 04 Jun 2014 17:23:38 +0100 Message-ID: <538F480A.50206@linaro.org> References: <538D9161.6090402@linaro.org> <1401897998-29569-1-git-send-email-talex5@gmail.com> <1401897998-29569-4-git-send-email-talex5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WsDyY-0007vI-93 for xen-devel@lists.xenproject.org; Wed, 04 Jun 2014 16:23:42 +0000 Received: by mail-wg0-f46.google.com with SMTP id n12so8605943wgh.17 for ; Wed, 04 Jun 2014 09:23:40 -0700 (PDT) In-Reply-To: <1401897998-29569-4-git-send-email-talex5@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Thomas Leonard , xen-devel@lists.xenproject.org, "karim.allah.ahmed@gmail.com" List-Id: xen-devel@lists.xenproject.org Hi Thomas, I'm not sure why you dropped everyone in cc (i.e Minios Maintainers & Karim). On 06/04/2014 05:06 PM, Thomas Leonard wrote: > diff --git a/extras/mini-os/events.c b/extras/mini-os/events.c > index 2da9b01..c2bda1a 100644 > --- a/extras/mini-os/events.c > +++ b/extras/mini-os/events.c [..] > + > + arch_init_events(); > } > > +void arch_fini_events(void); It's better to define the prototype in an header so the compiler can check if the function declaration is actually matching the prototype. This will avoid error if someone decide to modify the function declaration without modifying the call-site... I'm planning to send a patch to enable -Wmissing-prototypes on the hypervisor side. It might be a good idea to enable -Wmissing-prototypes on mini-os. Regards, -- Julien Grall