From: George Dunlap <george.dunlap@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com
Subject: Re: [PATCH v1 2/5] libxc/trace: Add xc_tbuf_set_cpu_mask_array a variant of xc_tbuf_set_cpu_mask (v3)
Date: Wed, 4 Jun 2014 17:52:27 +0100 [thread overview]
Message-ID: <538F4ECB.90804@eu.citrix.com> (raw)
In-Reply-To: <538F4D41.8070806@eu.citrix.com>
On 06/04/2014 05:45 PM, George Dunlap wrote:
> On 06/04/2014 02:44 PM, Konrad Rzeszutek Wilk wrote:
>> which uses an xc_cpumap_t instead of a uint32_t. This means
>> we can use an arbitrary bitmap without being limited to the
>> 32-bits the xc_tbuf_set_cpu_mask_array can only do.
>>
>> We also add an macro which can be used by both libxc and
>> xentrace.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> [v2: Use DIV_ROUND_UP macro as suggested by Daniel]
>> [v3: Use 'int' for bits instead of 'unsigned int' as spotted by Boris]
>
>
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
Oh, sorry -- I meant to say: from what I can tell, at the moment
xentrace is the only user of xc_tbuf_set_cpu_mask(). The libxc
interface isn't stable: why not just leave the name
xc_tbuf_set_cpu_mask() and just change the arguments? (This would
obviously involve merging patch 4 into this one as well.)
-George
next prev parent reply other threads:[~2014-06-04 16:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 13:44 [PATCH v1] Misc fixes to xentrace, docs, and add code to support selective human CPU selection Konrad Rzeszutek Wilk
2014-06-04 13:44 ` [PATCH v1 1/5] docs: xentrace manpage Konrad Rzeszutek Wilk
2014-06-04 16:25 ` George Dunlap
2014-06-05 13:31 ` Ian Campbell
2014-06-04 13:44 ` [PATCH v1 2/5] libxc/trace: Add xc_tbuf_set_cpu_mask_array a variant of xc_tbuf_set_cpu_mask (v3) Konrad Rzeszutek Wilk
2014-06-04 16:45 ` George Dunlap
2014-06-04 16:52 ` George Dunlap [this message]
2014-06-13 17:52 ` Konrad Rzeszutek Wilk
2014-06-05 12:49 ` Ian Campbell
2014-06-13 18:30 ` Konrad Rzeszutek Wilk
2014-06-04 13:44 ` [PATCH v1 3/5] libxc/trace: Fix style Konrad Rzeszutek Wilk
2014-06-04 16:46 ` George Dunlap
2014-06-04 13:44 ` [PATCH v1 4/5] xentrace: Use xc_cpumask_t when setting the cpu mask (v4) Konrad Rzeszutek Wilk
2014-06-04 17:01 ` George Dunlap
2014-06-05 12:55 ` Ian Campbell
2014-06-04 13:44 ` [PATCH v1 5/5] xentrace: Implement cpu mask range parsing of human values (-C) Konrad Rzeszutek Wilk
2014-06-04 17:18 ` George Dunlap
2014-06-13 19:57 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F4ECB.90804@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).