[RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Luis R. Rodriguez]

From: "Luis R. Rodriguez" <mcgrof@suse.com>

Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---

Hey folks, shiny kvm has a shortcut 'make kvmconfig' on the
kernel, and I thought this was a good idea so wanted to add a
respective helper for xen. Contrary to kvm though we can have
a dom0 and a guest kernel configuration. As it is right now this
patch bundles the same exact options for both, but figured
folks might already have special configs for both different
types. What options would we want as default *upstream* for each
of these ?

Please note that since this is going upstream it makes no sense
to add things which are not upstream though.

Thanks,

  Luis

 arch/x86/Makefile                 | 12 ++++++++++++
 arch/x86/configs/xen_dom0.config  | 37 +++++++++++++++++++++++++++++++++++++
 arch/x86/configs/xen_guest.config | 37 +++++++++++++++++++++++++++++++++++++
 3 files changed, 86 insertions(+)
 create mode 100644 arch/x86/configs/xen_dom0.config
 create mode 100644 arch/x86/configs/xen_guest.config

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 33f71b0..8b2bada 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -256,6 +256,16 @@ kvmconfig:
 	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh -m -O $(objtree) $(objtree)/.config $(srctree)/arch/x86/configs/kvm_guest.config
 	$(Q)yes "" | $(MAKE) -f $(srctree)/Makefile oldconfig
 
+xendom0config:
+	$(if $(wildcard $(objtree)/.config),, $(error You need an existing .config for this target))
+	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh -m -O $(objtree) $(objtree)/.config $(srctree)/arch/x86/configs/xen_dom0.config
+	$(Q)yes "" | $(MAKE) -f $(srctree)/Makefile oldconfig
+
+xenguestconfig:
+	$(if $(wildcard $(objtree)/.config),, $(error You need an existing .config for this target))
+	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh -m -O $(objtree) $(objtree)/.config $(srctree)/arch/x86/configs/xen_guest.config
+	$(Q)yes "" | $(MAKE) -f $(srctree)/Makefile oldconfig
+
 define archhelp
   echo  '* bzImage      - Compressed kernel image (arch/x86/boot/bzImage)'
   echo  '  install      - Install kernel using'
@@ -270,4 +280,6 @@ define archhelp
   echo  '                  FDARGS="..."  arguments for the booted kernel'
   echo  '                  FDINITRD=file initrd for the booted kernel'
   echo  '  kvmconfig	- Enable additional options for guest kernel support'
+  echo  '  xendom0config  - Enable additional options for xen dom0 kernel support'
+  echo  '  xenguestconfig - Enable additional options for xen guest kernel support'
 endef
diff --git a/arch/x86/configs/xen_dom0.config b/arch/x86/configs/xen_dom0.config
new file mode 100644
index 0000000..3f155e0
--- /dev/null
+++ b/arch/x86/configs/xen_dom0.config
@@ -0,0 +1,37 @@
+CONFIG_XEN=y
+CONFIG_XEN_DOM0=y
+CONFIG_XEN_PVHVM=y
+CONFIG_XEN_MAX_DOMAIN_MEMORY=500
+CONFIG_XEN_SAVE_RESTORE=y
+# CONFIG_XEN_DEBUG_FS is not set
+CONFIG_XEN_PVH=y
+CONFIG_PCI_XEN=y
+CONFIG_XEN_PCIDEV_FRONTEND=m
+CONFIG_XEN_BLKDEV_FRONTEND=m
+CONFIG_XEN_BLKDEV_BACKEND=m
+CONFIG_NETXEN_NIC=m
+CONFIG_XEN_NETDEV_FRONTEND=m
+CONFIG_XEN_NETDEV_BACKEND=m
+CONFIG_INPUT_XEN_KBDDEV_FRONTEND=y
+CONFIG_HVC_XEN=y
+CONFIG_HVC_XEN_FRONTEND=y
+# CONFIG_TCG_XEN is not set
+CONFIG_XEN_WDT=m
+CONFIG_XEN_FBDEV_FRONTEND=y
+CONFIG_XEN_BALLOON=y
+CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y
+CONFIG_XEN_SCRUB_PAGES=y
+CONFIG_XEN_DEV_EVTCHN=m
+CONFIG_XEN_BACKEND=y
+CONFIG_XENFS=m
+CONFIG_XEN_COMPAT_XENFS=y
+CONFIG_XEN_SYS_HYPERVISOR=y
+CONFIG_XEN_XENBUS_FRONTEND=y
+CONFIG_XEN_GNTDEV=m
+CONFIG_XEN_GRANT_DEV_ALLOC=m
+CONFIG_SWIOTLB_XEN=y
+CONFIG_XEN_PCIDEV_BACKEND=m
+CONFIG_XEN_PRIVCMD=m
+CONFIG_XEN_ACPI_PROCESSOR=m
+# CONFIG_XEN_MCE_LOG is not set
+CONFIG_XEN_HAVE_PVMMU=y
diff --git a/arch/x86/configs/xen_guest.config b/arch/x86/configs/xen_guest.config
new file mode 100644
index 0000000..3f155e0
--- /dev/null
+++ b/arch/x86/configs/xen_guest.config
@@ -0,0 +1,37 @@
+CONFIG_XEN=y
+CONFIG_XEN_DOM0=y
+CONFIG_XEN_PVHVM=y
+CONFIG_XEN_MAX_DOMAIN_MEMORY=500
+CONFIG_XEN_SAVE_RESTORE=y
+# CONFIG_XEN_DEBUG_FS is not set
+CONFIG_XEN_PVH=y
+CONFIG_PCI_XEN=y
+CONFIG_XEN_PCIDEV_FRONTEND=m
+CONFIG_XEN_BLKDEV_FRONTEND=m
+CONFIG_XEN_BLKDEV_BACKEND=m
+CONFIG_NETXEN_NIC=m
+CONFIG_XEN_NETDEV_FRONTEND=m
+CONFIG_XEN_NETDEV_BACKEND=m
+CONFIG_INPUT_XEN_KBDDEV_FRONTEND=y
+CONFIG_HVC_XEN=y
+CONFIG_HVC_XEN_FRONTEND=y
+# CONFIG_TCG_XEN is not set
+CONFIG_XEN_WDT=m
+CONFIG_XEN_FBDEV_FRONTEND=y
+CONFIG_XEN_BALLOON=y
+CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y
+CONFIG_XEN_SCRUB_PAGES=y
+CONFIG_XEN_DEV_EVTCHN=m
+CONFIG_XEN_BACKEND=y
+CONFIG_XENFS=m
+CONFIG_XEN_COMPAT_XENFS=y
+CONFIG_XEN_SYS_HYPERVISOR=y
+CONFIG_XEN_XENBUS_FRONTEND=y
+CONFIG_XEN_GNTDEV=m
+CONFIG_XEN_GRANT_DEV_ALLOC=m
+CONFIG_SWIOTLB_XEN=y
+CONFIG_XEN_PCIDEV_BACKEND=m
+CONFIG_XEN_PRIVCMD=m
+CONFIG_XEN_ACPI_PROCESSOR=m
+# CONFIG_XEN_MCE_LOG is not set
+CONFIG_XEN_HAVE_PVMMU=y
-- 
2.0.0.rc3.18.g00a5b79

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[David Vrabel]

On 05/06/14 01:48, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> ---
> 
> Hey folks, shiny kvm has a shortcut 'make kvmconfig' on the
> kernel, and I thought this was a good idea so wanted to add a
> respective helper for xen. Contrary to kvm though we can have
> a dom0 and a guest kernel configuration. As it is right now this
> patch bundles the same exact options for both, but figured
> folks might already have special configs for both different
> types. What options would we want as default *upstream* for each
> of these ?

This looks like a good idea but I would only have one Xen option.  There
are so few options that only apply to dom0 that it doesn't make sense to
have a dom0 option.

> --- /dev/null
> +++ b/arch/x86/configs/xen_dom0.config

Make this xen.config

> @@ -0,0 +1,37 @@
> +CONFIG_XEN=y
> +CONFIG_XEN_DOM0=y
> +CONFIG_XEN_PVHVM=y
> +CONFIG_XEN_MAX_DOMAIN_MEMORY=500
> +CONFIG_XEN_SAVE_RESTORE=y
> +# CONFIG_XEN_DEBUG_FS is not set
> +CONFIG_XEN_PVH=y
> +CONFIG_PCI_XEN=y
> +CONFIG_XEN_PCIDEV_FRONTEND=m
> +CONFIG_XEN_BLKDEV_FRONTEND=m
> +CONFIG_XEN_BLKDEV_BACKEND=m
> +CONFIG_NETXEN_NIC=m

Remove this as it isn't a Xen related option, but an ethernet driver.

> +CONFIG_XEN_NETDEV_FRONTEND=m
> +CONFIG_XEN_NETDEV_BACKEND=m
> +CONFIG_INPUT_XEN_KBDDEV_FRONTEND=y
> +CONFIG_HVC_XEN=y
> +CONFIG_HVC_XEN_FRONTEND=y
> +# CONFIG_TCG_XEN is not set

Enable as a module.

> +CONFIG_XEN_WDT=m
> +CONFIG_XEN_FBDEV_FRONTEND=y
> +CONFIG_XEN_BALLOON=y
> +CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y
> +CONFIG_XEN_SCRUB_PAGES=y
> +CONFIG_XEN_DEV_EVTCHN=m
> +CONFIG_XEN_BACKEND=y
> +CONFIG_XENFS=m
> +CONFIG_XEN_COMPAT_XENFS=y
> +CONFIG_XEN_SYS_HYPERVISOR=y
> +CONFIG_XEN_XENBUS_FRONTEND=y
> +CONFIG_XEN_GNTDEV=m
> +CONFIG_XEN_GRANT_DEV_ALLOC=m
> +CONFIG_SWIOTLB_XEN=y
> +CONFIG_XEN_PCIDEV_BACKEND=m
> +CONFIG_XEN_PRIVCMD=m
> +CONFIG_XEN_ACPI_PROCESSOR=m
> +# CONFIG_XEN_MCE_LOG is not set
> +CONFIG_XEN_HAVE_PVMMU=y

David

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Ian Campbell]

On Thu, 2014-06-05 at 10:44 +0100, David Vrabel wrote:
> On 05/06/14 01:48, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> > ---
> > 
> > Hey folks, shiny kvm has a shortcut 'make kvmconfig' on the
> > kernel, and I thought this was a good idea so wanted to add a
> > respective helper for xen. Contrary to kvm though we can have
> > a dom0 and a guest kernel configuration. As it is right now this
> > patch bundles the same exact options for both, but figured
> > folks might already have special configs for both different
> > types. What options would we want as default *upstream* for each
> > of these ?
> 
> This looks like a good idea but I would only have one Xen option.  There
> are so few options that only apply to dom0 that it doesn't make sense to
> have a dom0 option.

FWIW I agree. Having done that though, what about combining it with
kvmconfig to make virtconfig or something?

Ian.

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Luis R. Rodriguez]

On Fri, Jun 6, 2014 at 2:56 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> FWIW I agree. Having done that though, what about combining it with
> kvmconfig to make virtconfig or something?

Sure, as a separate new config, yeah I think it would be helpful so
long as we can combine two config inputs so that burden maintenance is
not shared.

  Luis

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Ian Campbell]

On Fri, 2014-06-06 at 11:49 -0700, Luis R. Rodriguez wrote:
> On Fri, Jun 6, 2014 at 2:56 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > FWIW I agree. Having done that though, what about combining it with
> > kvmconfig to make virtconfig or something?
> 
> Sure, as a separate new config, yeah I think it would be helpful so
> long as we can combine two config inputs so that burden maintenance is
> not shared.

BTW, I really meant this as a question to the x86 maintainers, or
whoever is responsible for the kvmconfig thing, but I hadn't noticed
that this patch only went to xen-devel and not the kernel lists. You'll
probably want to get some sort of consensus there before pressing ahead
with the merge.

Ian.

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Luis R. Rodriguez]

On Thu, Jun 05, 2014 at 10:44:13AM +0100, David Vrabel wrote:
> On 05/06/14 01:48, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> > ---
> > 
> > Hey folks, shiny kvm has a shortcut 'make kvmconfig' on the
> > kernel, and I thought this was a good idea so wanted to add a
> > respective helper for xen. Contrary to kvm though we can have
> > a dom0 and a guest kernel configuration. As it is right now this
> > patch bundles the same exact options for both, but figured
> > folks might already have special configs for both different
> > types. What options would we want as default *upstream* for each
> > of these ?
> 
> This looks like a good idea but I would only have one Xen option.  There
> are so few options that only apply to dom0 that it doesn't make sense to
> have a dom0 option.

OK thanks for the feedback I've merged them.

> > --- /dev/null
> > +++ b/arch/x86/configs/xen_dom0.config
> 
> Make this xen.config

Done.

> > @@ -0,0 +1,37 @@
> > +CONFIG_XEN=y
> > +CONFIG_XEN_DOM0=y
> > +CONFIG_XEN_PVHVM=y
> > +CONFIG_XEN_MAX_DOMAIN_MEMORY=500
> > +CONFIG_XEN_SAVE_RESTORE=y
> > +# CONFIG_XEN_DEBUG_FS is not set
> > +CONFIG_XEN_PVH=y
> > +CONFIG_PCI_XEN=y
> > +CONFIG_XEN_PCIDEV_FRONTEND=m
> > +CONFIG_XEN_BLKDEV_FRONTEND=m
> > +CONFIG_XEN_BLKDEV_BACKEND=m
> > +CONFIG_NETXEN_NIC=m
> 
> Remove this as it isn't a Xen related option, but an ethernet driver.

OK.

> > +CONFIG_XEN_NETDEV_FRONTEND=m
> > +CONFIG_XEN_NETDEV_BACKEND=m
> > +CONFIG_INPUT_XEN_KBDDEV_FRONTEND=y
> > +CONFIG_HVC_XEN=y
> > +CONFIG_HVC_XEN_FRONTEND=y
> > +# CONFIG_TCG_XEN is not set
> 
> Enable as a module.

Done.

  Luis

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Konrad Rzeszutek Wilk]

On Wed, Jun 04, 2014 at 05:48:19PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> ---
> 
> Hey folks, shiny kvm has a shortcut 'make kvmconfig' on the
> kernel, and I thought this was a good idea so wanted to add a
> respective helper for xen. Contrary to kvm though we can have
> a dom0 and a guest kernel configuration. As it is right now this
> patch bundles the same exact options for both, but figured
> folks might already have special configs for both different
> types. What options would we want as default *upstream* for each
> of these ?
> 
> Please note that since this is going upstream it makes no sense
> to add things which are not upstream though.
> 
> Thanks,
> 
>   Luis
> 
>  arch/x86/Makefile                 | 12 ++++++++++++
>  arch/x86/configs/xen_dom0.config  | 37 +++++++++++++++++++++++++++++++++++++
>  arch/x86/configs/xen_guest.config | 37 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 86 insertions(+)
>  create mode 100644 arch/x86/configs/xen_dom0.config
>  create mode 100644 arch/x86/configs/xen_guest.config
> 
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 33f71b0..8b2bada 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -256,6 +256,16 @@ kvmconfig:
>  	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh -m -O $(objtree) $(objtree)/.config $(srctree)/arch/x86/configs/kvm_guest.config
>  	$(Q)yes "" | $(MAKE) -f $(srctree)/Makefile oldconfig
>  
> +xendom0config:
> +	$(if $(wildcard $(objtree)/.config),, $(error You need an existing .config for this target))
> +	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh -m -O $(objtree) $(objtree)/.config $(srctree)/arch/x86/configs/xen_dom0.config
> +	$(Q)yes "" | $(MAKE) -f $(srctree)/Makefile oldconfig
> +
> +xenguestconfig:
> +	$(if $(wildcard $(objtree)/.config),, $(error You need an existing .config for this target))
> +	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh -m -O $(objtree) $(objtree)/.config $(srctree)/arch/x86/configs/xen_guest.config
> +	$(Q)yes "" | $(MAKE) -f $(srctree)/Makefile oldconfig
> +
>  define archhelp
>    echo  '* bzImage      - Compressed kernel image (arch/x86/boot/bzImage)'
>    echo  '  install      - Install kernel using'
> @@ -270,4 +280,6 @@ define archhelp
>    echo  '                  FDARGS="..."  arguments for the booted kernel'
>    echo  '                  FDINITRD=file initrd for the booted kernel'
>    echo  '  kvmconfig	- Enable additional options for guest kernel support'
> +  echo  '  xendom0config  - Enable additional options for xen dom0 kernel support'
> +  echo  '  xenguestconfig - Enable additional options for xen guest kernel support'
>  endef
> diff --git a/arch/x86/configs/xen_dom0.config b/arch/x86/configs/xen_dom0.config
> new file mode 100644
> index 0000000..3f155e0
> --- /dev/null
> +++ b/arch/x86/configs/xen_dom0.config
> @@ -0,0 +1,37 @@
> +CONFIG_XEN=y
> +CONFIG_XEN_DOM0=y
> +CONFIG_XEN_PVHVM=y
> +CONFIG_XEN_MAX_DOMAIN_MEMORY=500
> +CONFIG_XEN_SAVE_RESTORE=y
> +# CONFIG_XEN_DEBUG_FS is not set
> +CONFIG_XEN_PVH=y
> +CONFIG_PCI_XEN=y
> +CONFIG_XEN_PCIDEV_FRONTEND=m
> +CONFIG_XEN_BLKDEV_FRONTEND=m
> +CONFIG_XEN_BLKDEV_BACKEND=m
> +CONFIG_NETXEN_NIC=m
> +CONFIG_XEN_NETDEV_FRONTEND=m
> +CONFIG_XEN_NETDEV_BACKEND=m
> +CONFIG_INPUT_XEN_KBDDEV_FRONTEND=y
> +CONFIG_HVC_XEN=y
> +CONFIG_HVC_XEN_FRONTEND=y
> +# CONFIG_TCG_XEN is not set
> +CONFIG_XEN_WDT=m
> +CONFIG_XEN_FBDEV_FRONTEND=y
> +CONFIG_XEN_BALLOON=y
> +CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y
> +CONFIG_XEN_SCRUB_PAGES=y
> +CONFIG_XEN_DEV_EVTCHN=m
> +CONFIG_XEN_BACKEND=y
> +CONFIG_XENFS=m
> +CONFIG_XEN_COMPAT_XENFS=y
> +CONFIG_XEN_SYS_HYPERVISOR=y
> +CONFIG_XEN_XENBUS_FRONTEND=y
> +CONFIG_XEN_GNTDEV=m
> +CONFIG_XEN_GRANT_DEV_ALLOC=m
> +CONFIG_SWIOTLB_XEN=y
> +CONFIG_XEN_PCIDEV_BACKEND=m
> +CONFIG_XEN_PRIVCMD=m
> +CONFIG_XEN_ACPI_PROCESSOR=m
> +# CONFIG_XEN_MCE_LOG is not set

Probably want that on.

> +CONFIG_XEN_HAVE_PVMMU=y
> diff --git a/arch/x86/configs/xen_guest.config b/arch/x86/configs/xen_guest.config
> new file mode 100644
> index 0000000..3f155e0
> --- /dev/null
> +++ b/arch/x86/configs/xen_guest.config
> @@ -0,0 +1,37 @@
> +CONFIG_XEN=y
> +CONFIG_XEN_DOM0=y
> +CONFIG_XEN_PVHVM=y
> +CONFIG_XEN_MAX_DOMAIN_MEMORY=500
> +CONFIG_XEN_SAVE_RESTORE=y
> +# CONFIG_XEN_DEBUG_FS is not set
> +CONFIG_XEN_PVH=y
> +CONFIG_PCI_XEN=y
> +CONFIG_XEN_PCIDEV_FRONTEND=m
> +CONFIG_XEN_BLKDEV_FRONTEND=m
> +CONFIG_XEN_BLKDEV_BACKEND=m
> +CONFIG_NETXEN_NIC=m
> +CONFIG_XEN_NETDEV_FRONTEND=m
> +CONFIG_XEN_NETDEV_BACKEND=m
> +CONFIG_INPUT_XEN_KBDDEV_FRONTEND=y
> +CONFIG_HVC_XEN=y
> +CONFIG_HVC_XEN_FRONTEND=y
> +# CONFIG_TCG_XEN is not set
> +CONFIG_XEN_WDT=m
> +CONFIG_XEN_FBDEV_FRONTEND=y
> +CONFIG_XEN_BALLOON=y
> +CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y
> +CONFIG_XEN_SCRUB_PAGES=y
> +CONFIG_XEN_DEV_EVTCHN=m
> +CONFIG_XEN_BACKEND=y
> +CONFIG_XENFS=m
> +CONFIG_XEN_COMPAT_XENFS=y
> +CONFIG_XEN_SYS_HYPERVISOR=y
> +CONFIG_XEN_XENBUS_FRONTEND=y
> +CONFIG_XEN_GNTDEV=m
> +CONFIG_XEN_GRANT_DEV_ALLOC=m
> +CONFIG_SWIOTLB_XEN=y
> +CONFIG_XEN_PCIDEV_BACKEND=m
> +CONFIG_XEN_PRIVCMD=m
> +CONFIG_XEN_ACPI_PROCESSOR=m
> +# CONFIG_XEN_MCE_LOG is not set
> +CONFIG_XEN_HAVE_PVMMU=y
> -- 
> 2.0.0.rc3.18.g00a5b79
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [RFC v1] x86, platform, xen, kconfig: add xen defconfig helpers

[Luis R. Rodriguez]

On Thu, Jun 05, 2014 at 01:14:26PM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 04, 2014 at 05:48:19PM -0700, Luis R. Rodriguez wrote:
> > +# CONFIG_XEN_MCE_LOG is not set
> 
> Probably want that on.

Enabled.

  Luis