From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 6/7] mini-os: Added rmb to xenbus code
Date: Thu, 05 Jun 2014 14:55:53 +0100
Message-ID: <539076E9.4020007@linaro.org>
References: <538D9161.6090402@linaro.org>	<1401897998-29569-1-git-send-email-talex5@gmail.com>
	<1401897998-29569-7-git-send-email-talex5@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WsY97-0005U9-VH
	for xen-devel@lists.xenproject.org; Thu, 05 Jun 2014 13:55:58 +0000
Received: by mail-wg0-f45.google.com with SMTP id m15so1168618wgh.16
	for <xen-devel@lists.xenproject.org>;
	Thu, 05 Jun 2014 06:55:56 -0700 (PDT)
In-Reply-To: <1401897998-29569-7-git-send-email-talex5@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Hi Thomas,

Thank you for the patch.

On 06/04/2014 05:06 PM, Thomas Leonard wrote:
> From: Karim Raslan <karim.allah.ahmed@gmail.com>
> 
> Signed-off-by: Karim Allah Ahmed <karim.allah.ahmed@gmail.com>
> [talex5@gmail.com: separated from big ARM commit]
> Signed-off-by: Thomas Leonard <talex5@gmail.com>
> ---
>  extras/mini-os/xenbus/xenbus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/extras/mini-os/xenbus/xenbus.c b/extras/mini-os/xenbus/xenbus.c
> index d995020..8a99ee2 100644
> --- a/extras/mini-os/xenbus/xenbus.c
> +++ b/extras/mini-os/xenbus/xenbus.c
> @@ -450,6 +450,7 @@ xenbus_msg_reply(int type,
>      remove_waiter(w, req_info[id].waitq);
>      wake(current);
>  
> +    rmb();

Could you explain in the commit message why this rmb is necessary?

Regards,

-- 
Julien Grall