From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Yang Zhang <yang.z.zhang@intel.com>,
Kevin Tian <kevin.tian@intel.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/intel: Protect set_cpuidmask() against #GP faults
Date: Thu, 5 Jun 2014 16:00:56 +0100 [thread overview]
Message-ID: <53908628.60506@citrix.com> (raw)
In-Reply-To: <5390A1580200007800018508@mail.emea.novell.com>
On 05/06/14 15:56, Jan Beulich wrote:
>>>> On 05.06.14 at 16:24, <andrew.cooper3@citrix.com> wrote:
>> On 05/06/14 15:05, Jan Beulich wrote:
>>>>>> On 05.06.14 at 13:19, <andrew.cooper3@citrix.com> wrote:
>>>> * Call set_cpuidmask() unconditionally so faulting-capable hardware still gets
>>>> a log message indicating to the user why their command line arguments are
>>>> not taking effect.
>>> I don't think Intel will particularly like this part.
>> Why not?
> Because they try to deprecate masking in favor of CPUID faulting as
> much as they can.
>
> Jan
>
And that is a very good thing.
However, masking is only available SandyBridge and older (for a few
generations), whereas faulting is only available on IvyBridge and newer.
If the user tries setting the cpuid_mask_XXX in the hope that masking
occurs, It is kind to give them an error back explaining why nothing is
happening.
~Andrew
prev parent reply other threads:[~2014-06-05 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 11:19 [PATCH] x86/intel: Protect set_cpuidmask() against #GP faults Andrew Cooper
2014-06-05 14:05 ` Jan Beulich
2014-06-05 14:24 ` Andrew Cooper
2014-06-05 14:56 ` Jan Beulich
2014-06-05 15:00 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53908628.60506@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).