From: "Jan Beulich" <JBeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Eddie Dong <eddie.dong@intel.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2] xen: fix reboot/shutdown with running HVM guests
Date: Thu, 05 Jun 2014 14:38:39 +0100 [thread overview]
Message-ID: <53908EFF02000078000183F9@mail.emea.novell.com> (raw)
In-Reply-To: <1401968858-46165-1-git-send-email-roger.pau@citrix.com>
>>> On 05.06.14 at 13:47, <roger.pau@citrix.com> wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -83,6 +83,8 @@ static void vmx_invlpg_intercept(unsigned long vaddr);
>
> uint8_t __read_mostly posted_intr_vector;
>
> +DECLARE_PER_CPU(bool_t, vmxon);
This needs to go in a suitable VMX header.
And both of the early returns getting added in SVM and VMX code
should get a brief comment attached what they are for.
Jan
prev parent reply other threads:[~2014-06-05 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 11:47 [PATCH v2] xen: fix reboot/shutdown with running HVM guests Roger Pau Monne
2014-06-05 13:29 ` Boris Ostrovsky
2014-06-05 13:38 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53908EFF02000078000183F9@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).