From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH v2 15/17] libxl: allow usage of char devices as block backends Date: Thu, 5 Jun 2014 17:44:34 +0200 Message-ID: <53909062.7030800@citrix.com> References: <1401721703-34974-1-git-send-email-roger.pau@citrix.com> <1401721703-34974-16-git-send-email-roger.pau@citrix.com> <1401982897.15729.145.camel@hastur.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WsZsJ-0005Cd-94 for xen-devel@lists.xenproject.org; Thu, 05 Jun 2014 15:46:43 +0000 In-Reply-To: <1401982897.15729.145.camel@hastur.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org On 05/06/14 17:41, Ian Campbell wrote: > On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote: >> On FreeBSD ZVOLs/disks/partitions are char devices, so libxl must >> allow it's usage. > > Are they really, how... interesting... > > Do we think this should be made platform specific? This is already platform specific, see libxl__try_phy_backend in libxl_{linux/netbsd}.c, the problem is that we had this generic gate in libxl_device.c that only allows block or regular files to be tested for 'phy' support. If it's more suitable, I think we can get rid of this gate in libxl_device and rely on the OS specific version of libxl__try_phy_backend to do the checking. Roger.