From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2 01/17] configure: make the libaio test
 conditional on blktap1
Date: Thu, 5 Jun 2014 17:49:09 +0200
Message-ID: <53909175.6060106@citrix.com>
References: <1401721703-34974-1-git-send-email-roger.pau@citrix.com>	
	<1401721703-34974-2-git-send-email-roger.pau@citrix.com>
	<1401980789.15729.130.camel@hastur.hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WsZwV-0005dC-Q4
	for xen-devel@lists.xenproject.org; Thu, 05 Jun 2014 15:51:06 +0000
In-Reply-To: <1401980789.15729.130.camel@hastur.hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 05/06/14 17:06, Ian Campbell wrote:
> On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote:
>> libaio is only required for blktap1, so make the check conditional on
>> whether the user has requested blktap1 or not.
> 
> I think it is used for blktap2 as well.

OK, I have such a mess with blktap versions and which ones are inside of
the tree. Right now configure only allows enabling/disabling blktap1,
and blktap2 is compiled depending on the host OS version. Should I
change blktap2 to be selected on configure and disabled by default?
(just like blktap1)

> I thought blktap2 was Linux specific (and hence that the libaio could be
> too) but, from tools/Makefile:
> SUBDIRS-$(CONFIG_Linux) += blktap2
> SUBDIRS-$(CONFIG_NetBSD) += blktap2
> 
> I'm totally surprised by that! And TBH I find it a little hard to
> believe...

Yes, this is certainly a mistake, NetBSD never had anything similar to
blktap2 AFAIK.

Roger.