From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@citrix.com, xen-devel@lists.xensource.com,
Ian.Campbell@citrix.com
Subject: Re: [PATCH v4 1/4] xen/arm: observe itargets setting in vgic_enable_irqs and vgic_disable_irqs
Date: Mon, 09 Jun 2014 13:32:20 +0100 [thread overview]
Message-ID: <5395A954.1060104@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1406091303400.2526@kaball.uk.xensource.com>
On 06/09/2014 01:04 PM, Stefano Stabellini wrote:
> On Mon, 9 Jun 2014, Julien Grall wrote:
>> On 06/09/2014 11:47 AM, Stefano Stabellini wrote:
>>>> Write in GICD_ITARGETSR can be either half-word or word. If I'm not mistaken
>>>> you sanity check only handle word access.
>>>
>>> I realize that it is a bit tricky to read, but this works for both word
>>> and half-word accesses.
Hmmm... I meant byte access not half-word. Sorry.
>> I think you have to mask the unused bits in the register. We can't
>> assume that they will be all-zeroed.
>
> That's a good hint but I already pass 32 to find_next_bit as max bit to
> search for. The rest is ignored.
>
So if the byte is equal 0, then you can reach a one bit in the unused
part...
--
Julien Grall
next prev parent reply other threads:[~2014-06-09 12:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 17:47 [PATCH v4 0/4] vgic emulation and GICD_ITARGETSR Stefano Stabellini
2014-06-06 17:48 ` [PATCH v4 1/4] xen/arm: observe itargets setting in vgic_enable_irqs and vgic_disable_irqs Stefano Stabellini
2014-06-07 14:33 ` Julien Grall
2014-06-09 10:47 ` Stefano Stabellini
2014-06-09 11:37 ` Julien Grall
2014-06-09 12:04 ` Stefano Stabellini
2014-06-09 12:32 ` Julien Grall [this message]
2014-06-09 17:21 ` Stefano Stabellini
2014-06-10 11:44 ` Ian Campbell
2014-06-11 11:54 ` Stefano Stabellini
2014-06-06 17:48 ` [PATCH v4 2/4] xen/arm: inflight irqs during migration Stefano Stabellini
2014-06-10 12:12 ` Ian Campbell
2014-06-11 14:15 ` Stefano Stabellini
2014-06-11 14:28 ` Julien Grall
2014-06-11 14:49 ` Stefano Stabellini
2014-06-11 15:16 ` Julien Grall
2014-06-11 15:55 ` Stefano Stabellini
2014-06-06 17:48 ` [PATCH v4 3/4] xen/arm: support irq delivery to vcpu > 0 Stefano Stabellini
2014-06-10 12:16 ` Ian Campbell
2014-06-10 12:56 ` Julien Grall
2014-06-11 14:22 ` Stefano Stabellini
2014-06-06 17:48 ` [PATCH v4 4/4] xen/arm: physical irq follow virtual irq Stefano Stabellini
2014-06-10 12:27 ` Ian Campbell
2014-06-11 14:47 ` Stefano Stabellini
2014-06-11 15:14 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395A954.1060104@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).