From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 5/6] libxl: allow a generation ID to be specified at domain creation Date: Tue, 10 Jun 2014 13:35:02 +0100 Message-ID: <5396FB76.5010305@citrix.com> References: <1401801340-6196-1-git-send-email-david.vrabel@citrix.com> <1401801340-6196-6-git-send-email-david.vrabel@citrix.com> <1402398065.1250.36.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WuLGc-0000rs-P3 for xen-devel@lists.xenproject.org; Tue, 10 Jun 2014 12:35:06 +0000 In-Reply-To: <1402398065.1250.36.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 10/06/14 12:01, Ian Campbell wrote: > On Tue, 2014-06-03 at 14:15 +0100, David Vrabel wrote: >> Toolstacks may specify a VM generation ID using the >> u.hvm.generation_id field into libxl_domain_build_info structure, when >> creating a domain. >> >> The toolstack is responsible for providing the correct generation ID >> according to the Microsoft specification (e.g., generating new random >> ones as appropriate when restoring). > > Any reason not to make the libxl interface a (def)bool and have libxl > generate a suitable ID internally? Does anything ever care about the > specific UUID? Other toolstacks (like xapi) have a better idea of the life-cycle of a VM than xl does and thus need only use a new ID for snapshots -- they can retain the same ID if the domain is just rebooted/migrated. David