From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v2 2/6] xen/PMU: Sysfs interface for setting
	Xen PMU mode
Date: Tue, 10 Jun 2014 14:33:30 +0100
Message-ID: <5397092A.8060805@citrix.com>
References: <1402076686-26586-1-git-send-email-boris.ostrovsky@oracle.com>
	<1402076686-26586-3-git-send-email-boris.ostrovsky@oracle.com>
	<20140606201939.GA7896@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140606201939.GA7896@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: kevin.tian@intel.com, dietmar.hahn@ts.fujitsu.com, JBeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 06/06/14 21:19, Konrad Rzeszutek Wilk wrote:
> 
>> +static ssize_t pmu_mode_show(struct hyp_sysfs_attr *attr, char *buffer)
>> +{
>> +	int ret;
>> +	struct xen_pmu_params xp;
>> +	int i;
> 
> 'i' can be on the same line as 'ret'

No thanks.  Only do this if the two variables are related.

David