From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 1/6] xen: xensyms support
Date: Tue, 10 Jun 2014 11:03:37 -0400
Message-ID: <53971E49.2010003@oracle.com>
References: <1402076686-26586-1-git-send-email-boris.ostrovsky@oracle.com>
	<1402076686-26586-2-git-send-email-boris.ostrovsky@oracle.com>
	<539708A0.1020604@citrix.com> <53971B05.6020107@oracle.com>
	<539737870200007800019964@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <539737870200007800019964@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, David Vrabel <david.vrabel@citrix.com>, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 06/10/2014 10:51 AM, Jan Beulich wrote:
>>>> On 10.06.14 at 16:49, <boris.ostrovsky@oracle.com> wrote:
>> On 06/10/2014 09:31 AM, David Vrabel wrote:
>>>> --- /dev/null
>>>> +++ b/drivers/xen/xenfs/xensyms.c
>>>> @@ -0,0 +1,124 @@
>>>> +#include <linux/module.h>
>>>> +#include <linux/init.h>
>>>> +#include <linux/seq_file.h>
>>>> +#include <linux/fs.h>
>>>> +#include <linux/mm.h>
>>>> +#include <linux/proc_fs.h>
>>>> +#include <linux/slab.h>
>>>> +#include <xen/interface/platform.h>
>>>> +#include <asm/xen/hypercall.h>
>>>> +#include <xen/xen-ops.h>
>>>> +#include "xenfs.h"
>>>> +
>>>> +
>>>> +#define XEN_KSYM_NAME_LEN 127 /* Hypervisor may have different name length
>> */
>>> Shouldn't this be exported in the hypervisor headers then?
>>
>> Jan objected to having this as part of the interface so now we pass this
>> as a parameter to the hypervisor. I may return Xen's symbol length and,
>> if it is larger than XEN_KSYM_NAME_LEN, do a WARN_ONCE() (in the next
>> spin of the patch).
> The result of my objection should be you not hardcoding any number...

I guess I can query hypervisor's symbol size by passing to 
XENPF_get_symbol current symbol number as -1 (or some other token).

-boris