From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v7 02/19] VPMU: Mark context LOADED before
 registers are loaded
Date: Tue, 10 Jun 2014 11:40:32 -0400
Message-ID: <539726F0.70705@oracle.com>
References: <1402076415-26475-1-git-send-email-boris.ostrovsky@oracle.com>
	<1402076415-26475-3-git-send-email-boris.ostrovsky@oracle.com>
	<53920184.7090000@citrix.com>
	<539740760200007800019A07@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <539740760200007800019A07@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, keir@xen.org, suravee.suthikulpanit@amd.com, Andrew Cooper <andrew.cooper3@citrix.com>, tim@xen.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, jun.nakajima@intel.com
List-Id: xen-devel@lists.xenproject.org

On 06/10/2014 11:29 AM, Jan Beulich wrote:
>>>> On 06.06.14 at 19:59, <andrew.cooper3@citrix.com> wrote:
>> On 06/06/14 18:39, Boris Ostrovsky wrote:
>>> Because a PMU interrupt may be generated as soon as PMU registers are loaded (or,
>>> more precisely, as soon as HW PMU is "armed") we don't want to delay marking
>>> context as LOADED until after registers are loaded. Otherwise during interrupt
>>> handling VPMU_CONTEXT_LOADED may not be set and this could be confusing.
>>>
>>> (Technically, only SVM needs this change right now since VMX will "arm" PMU later,
>>> during VMRUN when global control register is loaded from VMCS. However, both
>>> AMD and Intel code will require this patch when we introduce PV VPMU).
>>>
>>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>> Acked-by: Kevin Tian <kevin.tian@intel.com>
>>> Reviewed-by: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
>>> Tested-by: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> With this not having seen other comments, does it make sense to
> apply this on its own, while you address comments you got on
> subsequent patches?

Yes, this can go in, especially given that it's the first patch 
affecting VPMU.

Thanks.
-boris