xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 5/6] libxl: allow a generation ID to be specified at domain creation
Date: Tue, 10 Jun 2014 18:59:23 +0100	[thread overview]
Message-ID: <5397477B.80801@citrix.com> (raw)
In-Reply-To: <1402398065.1250.36.camel@kazak.uk.xensource.com>

On 10/06/14 12:01, Ian Campbell wrote:
> On Tue, 2014-06-03 at 14:15 +0100, David Vrabel wrote:
> Should we consider calling the API field name something more specific,
> like "ms_vgid"? I'm thinking of the case where some other OS vendor
> reinvents the wheel. (I don't care about the internals, just the API).

generation_id matches the platform/generation-id xenstore key so I would
keep the libxl field name as-is.

> Do you not need to worry about endianess when memcpy'ing out of a uuid?

No. The conversion of uuid to the two 64-bit integers is arbitrary, it
need only be consistent.  The integers in guest memory are in native
endianness.

David

  parent reply	other threads:[~2014-06-10 17:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 13:15 [PATCHv3 0/6] tools: rework VM Generation ID David Vrabel
2014-06-03 13:15 ` [PATCH 1/6] docs: update docs for the ~/platform/generation-id key David Vrabel
2014-06-10 10:25   ` Ian Campbell
2014-06-03 13:15 ` [PATCH 2/6] hvm: add HVM_PARAM_VM_GENERATION_ID_ADDR David Vrabel
2014-06-03 13:19   ` Andrew Cooper
2014-06-10 10:27   ` Ian Campbell
2014-06-10 10:40     ` Jan Beulich
2014-06-10 10:44       ` Andrew Cooper
2014-06-10 10:49         ` Jan Beulich
2014-06-03 13:15 ` [PATCH 3/6] hvmloader: add helper functions to get/set HVM params David Vrabel
2014-06-03 19:43   ` Konrad Rzeszutek Wilk
2014-06-10 10:39     ` Ian Campbell
2014-06-03 13:15 ` [PATCH 4/6] libxc, libxl, hvmloader: strip out outdated VM generation ID implementation David Vrabel
2014-06-10 10:42   ` Ian Campbell
2014-06-03 13:15 ` [PATCH 5/6] libxl: allow a generation ID to be specified at domain creation David Vrabel
2014-06-03 13:28   ` Andrew Cooper
2014-06-03 14:14     ` David Vrabel
2014-06-10 11:01   ` Ian Campbell
2014-06-10 12:35     ` David Vrabel
2014-06-10 13:37       ` Ian Campbell
2014-06-10 13:41         ` David Vrabel
2014-06-10 14:18           ` Ian Campbell
2014-06-10 17:59     ` David Vrabel [this message]
2014-06-11  8:22       ` Ian Campbell
2014-06-11 10:53         ` David Vrabel
2014-06-11 11:01           ` Ian Campbell
2014-06-11 11:47             ` David Vrabel
2014-06-11 11:53               ` Ian Campbell
2014-06-03 13:15 ` [PATCH 6/6] xl: generate a new random VM generation ID if requested David Vrabel
2014-06-10 11:02   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5397477B.80801@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).