From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 5/6] libxl: allow a generation ID to be
 specified at domain creation
Date: Wed, 11 Jun 2014 11:53:59 +0100
Message-ID: <53983547.40703@citrix.com>
References: <1401801340-6196-1-git-send-email-david.vrabel@citrix.com>		
	<1401801340-6196-6-git-send-email-david.vrabel@citrix.com>	
	<1402398065.1250.36.camel@kazak.uk.xensource.com>	
	<5397477B.80801@citrix.com>
	<1402474966.9559.8.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1WugAN-0005ll-Bf
	for xen-devel@lists.xenproject.org; Wed, 11 Jun 2014 10:54:03 +0000
In-Reply-To: <1402474966.9559.8.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 11/06/14 09:22, Ian Campbell wrote:
> On Tue, 2014-06-10 at 18:59 +0100, David Vrabel wrote:
>> On 10/06/14 12:01, Ian Campbell wrote:
>>> On Tue, 2014-06-03 at 14:15 +0100, David Vrabel wrote:
>>> Should we consider calling the API field name something more specific,
>>> like "ms_vgid"? I'm thinking of the case where some other OS vendor
>>> reinvents the wheel. (I don't care about the internals, just the API).
>>
>> generation_id matches the platform/generation-id xenstore key so I would
>> keep the libxl field name as-is.
> 
> One is an internal implementation detail (we can update libx? and
> hvmloader in parallel if we have to) while the other is a stable API.

The specification is for a generic, non-Microsoft specific ACPI device
so I don't see the need to include ms_ in the field name.

>>> Do you not need to worry about endianess when memcpy'ing out of a uuid?
>>
>> No. The conversion of uuid to the two 64-bit integers is arbitrary, it
>> need only be consistent.  The integers in guest memory are in native
>> endianness.
> 
> OK. I was wondering if we might want to preserve the byte order so as
> not to trample any UUID format which is used.

The specification doesn't require that the ID is a UUID.

David