From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 16/16] xen/arm: add SGI handling for GICv3
Date: Wed, 11 Jun 2014 13:38:42 +0100
Message-ID: <53984DD2.3030804@linaro.org>
References: <1401100009-7326-1-git-send-email-vijay.kilari@gmail.com>	<1401100009-7326-17-git-send-email-vijay.kilari@gmail.com>	<538CA395.4000905@linaro.org>
	<CALicx6tkexqSgYVOh8FnW_zcc91FNLCB9syaeMRg7zq1bpqK7w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6tkexqSgYVOh8FnW_zcc91FNLCB9syaeMRg7zq1bpqK7w@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/11/2014 01:35 PM, Vijay Kilari wrote:
> On Mon, Jun 2, 2014 at 9:47 PM, Julien Grall <julien.grall@linaro.org> wrote:
>> Hi Vijay,
>>
>> On 05/26/2014 11:26 AM, vijay.kilari@gmail.com wrote:
>>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>>> index d80683d..99d0d46 100644
>>> --- a/xen/arch/arm/vgic-v3.c
>>> +++ b/xen/arch/arm/vgic-v3.c
>>
>> [..]
>>
>>> +int vgic_emulate(struct cpu_user_regs *regs, union hsr hsr)
>>> +{
>>
>> You are by-passing without any reason the vgic structure. Why didn't you
>> add a new callback there?
> 
> Sorry, I could not get you. Can you please be more clear?

Why didn't you add a callback in the vgic structure?

The vgic structure is per-domain, so it's perfectly valid (even though
it's not you use case) to run a GICv2 guest and a GICv3 guest at the
same time.

On the former, you don't want to let the guest send an SGI via this
solution.

Regards,

-- 
Julien Grall