From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 2/6] xen/PMU: Sysfs interface for setting
 Xen PMU mode
Date: Wed, 11 Jun 2014 08:53:13 -0400
Message-ID: <53985139.4090207@oracle.com>
References: <1402076686-26586-1-git-send-email-boris.ostrovsky@oracle.com>
	<1402076686-26586-3-git-send-email-boris.ostrovsky@oracle.com>
	<3204370.dMhetdKWtN@amur>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <3204370.dMhetdKWtN@amur>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Cc: kevin.tian@intel.com, david.vrabel@citrix.com, JBeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 06/11/2014 06:13 AM, Dietmar Hahn wrote:
>
> +
> +
> +/*
> + * PMU features:
> + * - XENPMU_FEATURE_INTEL_BTS: Intel BTS support (ignored on AMD)
> + */
> +#define XENPMU_FEATURE_INTEL_BTS  1
> Is this XENPMU_FEATURE_INTEL_BTS really needed on the the linux side?
> I would think it's a hypervisor internal feature.


Features are controlled (enabled/disabled) by dom0 via 
/sys/hypervisor/pmu/pmu_features so we need to have dom0 and the 
hypervisor agree on what the bits mean.

-boris