Re: [RFC 18/19] libxl: Add support for non-PCI passthrough

[Julien Grall <julien.grall@linaro.org>]

Hi Wei,

On 06/16/2014 06:19 PM, Wei Liu wrote:
> On Mon, Jun 16, 2014 at 05:18:05PM +0100, Julien Grall wrote:
> [...]
>>  /*----- xswait: wait for a xenstore node to be suitable -----*/
>>  
>>  typedef struct libxl__xswait_state libxl__xswait_state;
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> index 9201461..74ba20d 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -452,6 +452,10 @@ libxl_device_pci = Struct("device_pci", [
>>      ("seize", bool),
>>      ])
>>  
>> +libxl_device_dt = Struct("device_dt", [
>> +    ("path", string),
>> +    ])
>> +
>>  libxl_device_vtpm = Struct("device_vtpm", [
>>      ("backend_domid",    libxl_domid),
>>      ("backend_domname",  string),
>> @@ -466,6 +470,7 @@ libxl_domain_config = Struct("domain_config", [
>>      ("disks", Array(libxl_device_disk, "num_disks")),
>>      ("nics", Array(libxl_device_nic, "num_nics")),
>>      ("pcidevs", Array(libxl_device_pci, "num_pcidevs")),
>> +    ("dtdevs", Array(libxl_device_dt, "num_dtdevs")),
> 
> I would say let's go for "dts" instead of "dtdevs", just like "nics",
> "vtpms" etc. Or you can do it the other way around, make
> "libxl_device_dt" "libxl_device_dtdev". So that it follows the pattern

I find "dts" confusing because this is also the extension used for file
describing the device tree.

I will rename the structure libxl_device_dt in libxl_device_dtdev.

Regards,

-- 
Julien Grall