From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC 18/19] libxl: Add support for non-PCI
	passthrough
Date: Wed, 18 Jun 2014 13:26:39 +0100
Message-ID: <53A1857F.8010001@linaro.org>
References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org>
	<1402935486-29136-19-git-send-email-julien.grall@linaro.org>
	<20140616171927.GB1773@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WxEwt-0005kA-RR
	for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 12:26:44 +0000
Received: by mail-we0-f178.google.com with SMTP id x48so784385wes.9
	for <xen-devel@lists.xenproject.org>;
	Wed, 18 Jun 2014 05:26:42 -0700 (PDT)
In-Reply-To: <20140616171927.GB1773@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, tim@xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Hi Wei,

On 06/16/2014 06:19 PM, Wei Liu wrote:
> On Mon, Jun 16, 2014 at 05:18:05PM +0100, Julien Grall wrote:
> [...]
>>  /*----- xswait: wait for a xenstore node to be suitable -----*/
>>  
>>  typedef struct libxl__xswait_state libxl__xswait_state;
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> index 9201461..74ba20d 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -452,6 +452,10 @@ libxl_device_pci = Struct("device_pci", [
>>      ("seize", bool),
>>      ])
>>  
>> +libxl_device_dt = Struct("device_dt", [
>> +    ("path", string),
>> +    ])
>> +
>>  libxl_device_vtpm = Struct("device_vtpm", [
>>      ("backend_domid",    libxl_domid),
>>      ("backend_domname",  string),
>> @@ -466,6 +470,7 @@ libxl_domain_config = Struct("domain_config", [
>>      ("disks", Array(libxl_device_disk, "num_disks")),
>>      ("nics", Array(libxl_device_nic, "num_nics")),
>>      ("pcidevs", Array(libxl_device_pci, "num_pcidevs")),
>> +    ("dtdevs", Array(libxl_device_dt, "num_dtdevs")),
> 
> I would say let's go for "dts" instead of "dtdevs", just like "nics",
> "vtpms" etc. Or you can do it the other way around, make
> "libxl_device_dt" "libxl_device_dtdev". So that it follows the pattern

I find "dts" confusing because this is also the extension used for file
describing the device tree.

I will rename the structure libxl_device_dt in libxl_device_dtdev.

Regards,

-- 
Julien Grall