From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 05/19] xen/arm: Release IRQ routed to a domain when it's destroying Date: Wed, 18 Jun 2014 20:09:23 +0100 Message-ID: <53A1E3E3.8010804@linaro.org> References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> <1402935486-29136-6-git-send-email-julien.grall@linaro.org> <53A1D9D0.4070303@linaro.org> <53A1E06F.8050502@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxLEc-0002Ow-R5 for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 19:09:27 +0000 Received: by mail-we0-f176.google.com with SMTP id u56so1301196wes.21 for ; Wed, 18 Jun 2014 12:09:25 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On 18/06/14 20:06, Stefano Stabellini wrote: > At the moment gic_update_lrs is called on hypervisor entry, so whenever > the vcpu gets interrupted, gic_update_lrs is called. If > gic_reset_guest_irq is called always after all the guest vcpus have been > descheduled, IRQ_INPROGRESS is surely up to date and you don't need to > go through the lrs. Thanks. I will add a comment in the code explaining why IRQ_INPROGRESS is valid here. -- Julien Grall