From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 02/19] xen: guestcopy: Provide an helper to copy string from guest Date: Tue, 24 Jun 2014 15:58:38 +0100 Message-ID: <53A9921E.1090403@linaro.org> References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> <1402935486-29136-3-git-send-email-julien.grall@linaro.org> <53A011E4020000780001ADF4@mail.emea.novell.com> <53A005AC.3060306@linaro.org> <53A023E7020000780001AE8B@mail.emea.novell.com> <53A00903.2060904@linaro.org> <53A0C482.1090309@tycho.nsa.gov> <53A19B39020000780001B53A@mail.emea.novell.com> <53A18488.1030305@linaro.org> <53A1A6DE020000780001B5D6@mail.emea.novell.com> <53A18BB9.9020302@linaro.org> <53A1A9AC020000780001B60E@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WzSBK-0005gb-Q4 for xen-devel@lists.xenproject.org; Tue, 24 Jun 2014 14:58:46 +0000 Received: by mail-we0-f171.google.com with SMTP id q58so519141wes.30 for ; Tue, 24 Jun 2014 07:58:44 -0700 (PDT) In-Reply-To: <53A1A9AC020000780001B60E@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Daniel De Graaf Cc: Keir Fraser , ian.campbell@citrix.com, tim@xen.org, Ian Jackson , stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 06/18/2014 02:01 PM, Jan Beulich wrote: >> How will you rename the function? > > I don't know. All I know is that the function isn't simply coping in a > string. I though a bit more. I will rename function into safe_copy_string_from_guest and add a comment explain what this function really does (i.e adding a NUL-terminated). Regards, -- Julien Grall