xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
	Dushyant Behl <myselfdushyantbehl@gmail.com>
Cc: xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>,
	David Scott <dave.scott@eu.citrix.com>,
	Andres Lagar Cavilla <andres@lagarcavilla.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2 1/3] [GSOC14] refactored mempaging code from xenpaging to libxc.
Date: Fri, 27 Jun 2014 11:41:27 +0100	[thread overview]
Message-ID: <53AD4A57.8030108@citrix.com> (raw)
In-Reply-To: <1403865457.25894.16.camel@kazak.uk.xensource.com>

On 27/06/14 11:37, Ian Campbell wrote:
> On Fri, 2014-06-27 at 11:27 +0100, Ian Campbell wrote:
>> On Mon, 2014-06-16 at 23:50 +0530, Dushyant Behl wrote:
>>
>>> +    /* Now that the ring is set, remove it from the guest's physmap */
>>> +    if ( xc_domain_decrease_reservation_exact(xch, domain_id, 1, 0, &ring_pfn) )
>> ... the lack of a domain pause and/or clearing the ring content in this
>> function does not represent an issue similar to
>> http://xenbits.xen.org/xsa/advisory-99.html.
> I found the answer to this in patch #3, but I had questions on that so I
> haven't applied yet.

Doesn't c/s 6ae2df93c277, the fix for XSA-99 do change all of this anyway?

Patch #2 still looks valid, albeit against xc_mem_event.c, but #1 and #3
appear to have already been done differently.

~Andrew

  reply	other threads:[~2014-06-27 10:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 18:20 [PATCH v2 0/3] Refactoring mempaging code from xenpaging to libxc and few updates Dushyant Behl
2014-06-16 18:20 ` [PATCH v2 1/3] [GSOC14] refactored mempaging code from xenpaging to libxc Dushyant Behl
2014-06-27 10:27   ` Ian Campbell
2014-06-27 10:37     ` Ian Campbell
2014-06-27 10:41       ` Andrew Cooper [this message]
2014-06-27 10:39     ` Dushyant Behl
2014-06-27 12:39       ` Ian Campbell
2014-06-28  3:32         ` Dushyant Behl
2014-06-30 10:37           ` Ian Campbell
2014-06-27 10:39   ` Ian Campbell
2014-06-16 18:20 ` [PATCH v2 2/3] [GSOC14] Replacing Deprecated Function Calls Dushyant Behl
2014-06-16 18:20 ` [PATCH v2 3/3] [GSOC14] FIX:- Race condition between initializing shared ring and mempaging Dushyant Behl
2014-06-27 10:33   ` Ian Campbell
2014-07-20 21:49     ` Dushyant Behl
2014-07-21  7:31       ` Andres Lagar Cavilla
2014-07-21  9:01         ` Andrew Cooper
2014-07-21 14:11           ` Andres Lagar Cavilla
2014-07-21 14:40             ` Andrew Cooper
2014-07-21 15:59               ` Andres Lagar Cavilla
2014-07-22 18:21                 ` Dushyant Behl
2014-07-23 10:14               ` Ian Campbell
2014-07-23 10:32                 ` Andrew Cooper
2014-07-23 10:35                   ` Ian Campbell
2014-07-23 10:46                     ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AD4A57.8030108@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=andres@lagarcavilla.org \
    --cc=dave.scott@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=myselfdushyantbehl@gmail.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).