From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH v2 2/3] xen: introduce function
	merge_free_trunks
Date: Tue, 01 Jul 2014 16:14:06 +0800
Message-ID: <53B26DCE.7000105@oracle.com>
References: <1404135584-29206-1-git-send-email-bob.liu@oracle.com>
	<1404135584-29206-2-git-send-email-bob.liu@oracle.com>
	<53B1A52E020000780001EA70@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <bob.liu@oracle.com>) id 1X1tCl-0008G1-Ht
	for xen-devel@lists.xenproject.org; Tue, 01 Jul 2014 08:14:19 +0000
In-Reply-To: <53B1A52E020000780001EA70@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Bob Liu <lliubbo@gmail.com>, keir@xen.org, ian.campbell@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org


On 06/30/2014 11:58 PM, Jan Beulich wrote:
>>>> On 30.06.14 at 15:39, <lliubbo@gmail.com> wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -831,11 +831,73 @@ static int reserve_offlined_page(struct page_info *head)
>>      return count;
>>  }
>>  
>> +static void merge_free_trunks(struct page_info *pg, unsigned int order,
> 
> Did you perhaps mean merge_free_chunks(), ...

Oh, yes.

> 
>> @@ -891,59 +953,7 @@ static void free_heap_pages(
>>          }
>>      }
>>  
>> -    /* Merge chunks as far as possible. */
> 
> ... taking into consideration this comment the patch removes?
> 

I will fix these two issues.

Would you please also take a look at [PATCH v2 3/3]?

-- 
Regards,
-Bob