From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Implement domain_get_maximum_gpfn Date: Tue, 01 Jul 2014 19:36:17 +0100 Message-ID: <53B2FFA1.4050007@linaro.org> References: <1404226666-7949-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X22uj-0007ZK-Bn for xen-devel@lists.xenproject.org; Tue, 01 Jul 2014 18:36:21 +0000 Received: by mail-we0-f176.google.com with SMTP id u56so10202667wes.7 for ; Tue, 01 Jul 2014 11:36:19 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 01/07/14 17:57, Stefano Stabellini wrote: > On Tue, 1 Jul 2014, Julien Grall wrote: >> The function domain_get_maximum_gpfn is returning the maximum gpfn ever >> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose. >> >> Signed-off-by: Julien Grall > > Acked-by: Stefano Stabellini Thanks. Just a quick follow-up on your question on IRC. LPAE supports up to 48 bits on ARMv8 (40 bits on v7), so the MFN will just fit in 32 bits. I'm a bit worry about what happen if there is an error? The current hypercall doesn't look like to be safe for that. Indeed, the return value is used to store the higher gpfn. If the guest also use internal error, then we are screw. This is mostly an issue when the toolstack is running in 32 bits guest on 64 bits hypervisor. How x86 support this case? Stefano was suggesting to introduce a new hypercall XENMEM_maximum_gpfn_v2 which will take a pointer to a gpfn in parameter. Regards, -- Julien Grall