From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 04/19] xen/arm: route_irq_to_guest: Check validity of the IRQ Date: Thu, 03 Jul 2014 12:47:08 +0100 Message-ID: <53B542BC.2060906@linaro.org> References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> <1402935486-29136-5-git-send-email-julien.grall@linaro.org> <1404385478.14865.69.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X2fTu-0002Lq-MS for xen-devel@lists.xenproject.org; Thu, 03 Jul 2014 11:47:15 +0000 Received: by mail-we0-f179.google.com with SMTP id w62so97280wes.38 for ; Thu, 03 Jul 2014 04:47:13 -0700 (PDT) In-Reply-To: <1404385478.14865.69.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On 07/03/2014 12:04 PM, Ian Campbell wrote: > On Mon, 2014-06-16 at 17:17 +0100, Julien Grall wrote: >> diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h >> index e567f71..63926a5 100644 >> --- a/xen/include/asm-arm/irq.h >> +++ b/xen/include/asm-arm/irq.h >> @@ -37,6 +37,12 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq); >> >> #define domain_pirq_to_irq(d, pirq) (pirq) >> >> +static inline bool_t is_routable_irq(unsigned int irq) > > is_assignable_irq I think better suits your intention. > > routable doesn't imply "to the guest" since you might also route it to > Xen. Hmmm... right. I will do the change in the next version. Regards, -- Julien Grall