From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC 08/19] xen/dts: Provide an helper to get a DT
 node from a path provided by a guest
Date: Thu, 03 Jul 2014 13:22:42 +0100
Message-ID: <53B54B12.2080700@linaro.org>
References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org>		
	<1402935486-29136-9-git-send-email-julien.grall@linaro.org>	
	<1404387012.17859.12.camel@kazak.uk.xensource.com>	
	<53B54351.2060701@linaro.org>
	<1404389639.19893.2.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1X2g2K-0005V3-Ec
	for xen-devel@lists.xenproject.org; Thu, 03 Jul 2014 12:22:48 +0000
Received: by mail-we0-f178.google.com with SMTP id x48so147435wes.23
	for <xen-devel@lists.xenproject.org>;
	Thu, 03 Jul 2014 05:22:46 -0700 (PDT)
In-Reply-To: <1404389639.19893.2.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

On 07/03/2014 01:13 PM, Ian Campbell wrote:
> On Thu, 2014-07-03 at 12:49 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 07/03/2014 12:30 PM, Ian Campbell wrote:
>>> On Mon, 2014-06-16 at 17:17 +0100, Julien Grall wrote:
>>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>>> ---
>>>>  xen/common/device_tree.c      |   19 +++++++++++++++++++
>>>>  xen/include/xen/device_tree.h |   17 +++++++++++++++++
>>>>  2 files changed, 36 insertions(+)
>>>>
>>>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
>>>> index 4736e0d..fd95307 100644
>>>> --- a/xen/common/device_tree.c
>>>> +++ b/xen/common/device_tree.c
>>>> @@ -13,6 +13,7 @@
>>>>  #include <xen/config.h>
>>>>  #include <xen/types.h>
>>>>  #include <xen/init.h>
>>>> +#include <xen/guest_access.h>
>>>>  #include <xen/device_tree.h>
>>>>  #include <xen/kernel.h>
>>>>  #include <xen/lib.h>
>>>> @@ -661,6 +662,24 @@ struct dt_device_node *dt_find_node_by_path(const char *path)
>>>>      return np;
>>>>  }
>>>>  
>>>> +int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
>>>> +                          struct dt_device_node **node)
>>>
>>> My initial feeling is that this should be a static helper in whichever
>>> file is using this rather than part of the "dt library" interface.
>>
>> It's used in 2 different place (see patch #9 and #12).
> 
> domtctl and physdev op I think?

Yes.

> I suppose device_tree.c isn't so bad, I just felt odd putting guest
> specific stuff in there.

I can move in arch/arm/guestcopy.c. Even though for me it's not arch
specific but device tree specific.

Regards,

-- 
Julien Grall