From: Julien Grall <julien.grall@linaro.org>
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com,
tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com,
vijaya.kumar@caviumnetworks.com, keir@xen.org, jbeulich@suse.com
Subject: Re: [PATCH v6 1/5] xen/arm: Add support for GIC v3
Date: Thu, 03 Jul 2014 14:58:40 +0100 [thread overview]
Message-ID: <53B56190.2000703@linaro.org> (raw)
In-Reply-To: <1404376629-25252-2-git-send-email-vijay.kilari@gmail.com>
Hi Vijay,
On 07/03/2014 09:37 AM, vijay.kilari@gmail.com wrote:
> +static void __cpuinit gicv3_hyp_init(void)
> +{
> + uint32_t vtr;
> +
> + vtr = READ_SYSREG32(ICH_VTR_EL2);
> + gicv3_info.nr_lrs = (vtr & GICH_VTR_NRLRGS) + 1;
> + gicv3.nr_priorities = ((vtr >> GICH_VTR_PRIBITS_SHIFT) &
> + GICH_VTR_PRIBITS_MASK) + 1;
> +
> + if ( !((gicv3.nr_priorities > 4) && (gicv3.nr_priorities < 8)) )
> + dprintk(XENLOG_ERR, "GICv3: Invalid number of priority bits\n");
You already know that something is wrong, shouldn't you panic here?
Otherwise you will hit the BUG in {save,restore}_aprn_regs later.
> +
> + WRITE_SYSREG32(GICH_VMCR_EOI | GICH_VMCR_VENG1, ICH_VMCR_EL2);
> + WRITE_SYSREG32(GICH_HCR_EN, ICH_HCR_EL2);
> +}
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-03 13:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 8:37 [PATCH v6 0/5]xen/arm: Add GICv3 support vijay.kilari
2014-07-03 8:37 ` [PATCH v6 1/5] xen/arm: Add support for GIC v3 vijay.kilari
2014-07-03 9:09 ` Jan Beulich
2014-07-04 6:19 ` Vijay Kilari
2014-07-04 6:34 ` Jan Beulich
2014-07-16 10:30 ` Ian Campbell
2014-07-16 11:45 ` Vijay Kilari
2014-07-03 13:58 ` Julien Grall [this message]
2014-07-03 8:37 ` [PATCH v6 2/5] xen/arm: Add virtual GICv3 support vijay.kilari
2014-07-03 8:37 ` [PATCH v6 3/5] xen/arm: Update Dom0 GIC dt node with GICv3 information vijay.kilari
2014-07-03 8:37 ` [PATCH v6 4/5] xen/arm: add SGI handling for GICv3 vijay.kilari
2014-07-03 14:33 ` Julien Grall
2014-07-11 5:09 ` Vijay Kilari
2014-07-11 9:24 ` Ian Campbell
2014-07-03 8:37 ` [PATCH v6 5/5] xen/arm: check for GICv3 platform support vijay.kilari
2014-07-03 14:35 ` Julien Grall
2014-07-03 14:03 ` [PATCH v6 0/5]xen/arm: Add GICv3 support Julien Grall
2014-07-04 6:23 ` Vijay Kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B56190.2000703@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).